<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 1, 2011, at 3:39 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Mar 1, 2011, at 2:11 PM, Dan Gohman wrote:<br><br><blockquote type="cite">Author: djg<br></blockquote><blockquote type="cite">Date: Tue Mar 1 16:11:52 2011<br></blockquote><blockquote type="cite">New Revision: 126787<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=126787&view=rev">http://llvm.org/viewvc/llvm-project?rev=126787&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">Remove the showline argument from the SMDiagnostic constructor<br></blockquote><blockquote type="cite">which constructs a diagnostic with no line to show.<br></blockquote><br>Hi Dan,<br><br>Removing the option sounds fine, but doesn't this patch silently switch it from 'true' to 'false'?<br></div></blockquote><div><br></div><div>Yes, but since there's no line to show it doesn't matter.</div><div><br></div><div>Dan</div><div><br></div></div></body></html>