<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 25, 2011, at 1:48 PM, Bill Wendling wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Jan 19, 2011, at 10:21 PM, Andrew Trick wrote:<font class="Apple-style-span" color="#006312"><font class="Apple-style-span" color="#144FAE"><br></font></font><blockquote type="cite"> if (!PN->isMachineOpcode()) {<br></blockquote><blockquote type="cite">@@ -1814,7 +1826,9 @@<br></blockquote><blockquote type="cite"> if (I->isCtrl())<br></blockquote><blockquote type="cite"> continue;<br></blockquote><blockquote type="cite"> SUnit *PredSU = I->getSUnit();<br></blockquote><blockquote type="cite">- if (PredSU->NumSuccsLeft != PredSU->NumSuccs)<br></blockquote><blockquote type="cite">+ // NumSuccsLeft counts all deps. Don't compare it with NumSuccs which only<br></blockquote><blockquote type="cite">+ // counts data deps.<br></blockquote><blockquote type="cite">+ if (PredSU->NumSuccsLeft != PredSU->Succs.size())<br></blockquote><blockquote type="cite"> continue;<br></blockquote><blockquote type="cite"> const SDNode *PN = PredSU->getNode();<br></blockquote><blockquote type="cite"> if (!PN->isMachineOpcode()) {<br></blockquote><blockquote type="cite">@@ -2003,12 +2017,11 @@<br></blockquote><blockquote type="cite"> int LDepth = (int)left->getDepth();<br></blockquote><blockquote type="cite"> int RDepth = (int)right->getDepth();<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- DEBUG(dbgs() << " Comparing latency of SU #" << left->NodeNum<br></blockquote><blockquote type="cite">- << " depth " << LDepth << " vs SU #" << right->NodeNum<br></blockquote><blockquote type="cite">- << " depth " << RDepth << "\n");<br></blockquote><blockquote type="cite">-<br></blockquote><blockquote type="cite"> if (EnableSchedCycles) {<br></blockquote><blockquote type="cite"> if (LDepth != RDepth)<br></blockquote><blockquote type="cite">+ DEBUG(dbgs() << " Comparing latency of SU (" << left->NodeNum<br></blockquote><blockquote type="cite">+ << ") depth " << LDepth << " vs SU (" << right->NodeNum<br></blockquote><blockquote type="cite">+ << ") depth " << RDepth << ")\n");<br></blockquote><blockquote type="cite"> return LDepth < RDepth ? 1 : -1;<br></blockquote><br>Hi Andy,<br><br>Did you mean to move the return statement out of that if-statement?<br><br>-bw<br><br></div></blockquote><div><br></div><div>I did in the next commit. Thanks for checking though.</div><div><br></div><div>-Andy</div><br><blockquote type="cite"><div><blockquote type="cite"> }<br></blockquote><blockquote type="cite"> else {<br></blockquote><blockquote type="cite">@@ -2119,10 +2132,16 @@<br></blockquote><blockquote type="cite"> bool RHigh = SPQ->HighRegPressure(right);<br></blockquote><blockquote type="cite"> // Avoid causing spills. If register pressure is high, schedule for<br></blockquote><blockquote type="cite"> // register pressure reduction.<br></blockquote><blockquote type="cite">- if (LHigh && !RHigh)<br></blockquote><blockquote type="cite">+ if (LHigh && !RHigh) {<br></blockquote><blockquote type="cite">+ DEBUG(dbgs() << " pressure SU(" << left->NodeNum << ") > SU("<br></blockquote><blockquote type="cite">+ << right->NodeNum << ")\n");<br></blockquote><blockquote type="cite"> return true;<br></blockquote><blockquote type="cite">- else if (!LHigh && RHigh)<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ else if (!LHigh && RHigh) {<br></blockquote><blockquote type="cite">+ DEBUG(dbgs() << " pressure SU(" << right->NodeNum << ") > SU("<br></blockquote><blockquote type="cite">+ << left->NodeNum << ")\n");<br></blockquote><blockquote type="cite"> return false;<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite"> else if (!LHigh && !RHigh) {<br></blockquote><blockquote type="cite"> int result = BUCompareLatency(left, right, true /*checkPref*/, SPQ);<br></blockquote><blockquote type="cite"> if (result != 0)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">llvm-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><br></div></blockquote></div><br></body></html>