<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jan 10, 2011, at 1:18 AM, Chandler Carruth wrote:</div><blockquote type="cite"><div><div>define i32 @_Z1av() nounwind readnone {</div><div>entry:</div><div> ret i32 3</div><div>}</div></div><div><br></div>
<div>which looks pretty good to me. =]</div><div><br></div><div>One question, where is the best place to test this? I couldn't find a direct test for ConstantFolding.</div>
</blockquote><br></div><div>Very nice! test/Transforms/ConstProp is the best place for constant folding tests.</div><div><br></div><div>The patch looks reasonable to me, please add a doxygen comment to ConstantFoldConvertToInt though. Thanks Chandler!</div><br><div><br></div><div><span class="Apple-style-span" style="font-family: Menlo; font-size: 11px; ">-Chris</span></div><br></body></html>