<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Sorry about the long response time. A few general comments:<div><br></div><div>• Watch out for consistent spacing.</div><div>• You should use "llvm::next" instead of "next". The latter conflicts with an "std" name (if I recall correctly).</div><div><div><div>• You call 'new' on the Opportunity classes in a situation where it expects to return a "bool" value. What's going on here?</div><div><br></div><div>-bw</div><div><br><div><div>On Oct 25, 2010, at 1:28 AM, Gabor Greif wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Ping!<br><br>Attached the diff against recent trunk.<br><br>Cheers,<br><br> Gabor<br><br>On 10/21/10, Gabor Greif <<a href="mailto:ggreif@gmail.com">ggreif@gmail.com</a>> wrote:<br><blockquote type="cite">Hi all,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">the last weeks I've been working on a flexible infrastructure for<br></blockquote><blockquote type="cite">peephole optimizations, which is potentially target independent and<br></blockquote><blockquote type="cite">extensible without needing interface changes.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">The result of my work is attached. It moves all current ARM peepholes<br></blockquote><blockquote type="cite">over to the new architecture and adds TSTrr-related optimizations too.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">The ordering and forward referencing of functions is still suboptimal,<br></blockquote><blockquote type="cite">but this is only done to keep the patch size manageable. I plan to<br></blockquote><blockquote type="cite">reorder in a cleanup commit after this patch has landed. Also some<br></blockquote><blockquote type="cite">currently freestanding functions will become methods.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">You can also see the code in its entirety here:<br></blockquote><blockquote type="cite"><<a href="http://llvm.org/viewvc/llvm-project/llvm/branches/ggreif/peephole-infrastructure/">http://llvm.org/viewvc/llvm-project/llvm/branches/ggreif/peephole-infrastructure/</a>><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Feedback is welcome.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Cheers,<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> Gabor<br></blockquote><blockquote type="cite"><br></blockquote><span><peep-infra.patch></span></div></blockquote></div><br></div></div></div></body></html>