<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Nakamura,<div><br></div><div>The patch looks fine. Go ahead and apply it. If you want to tackle the other places where the ATTRIBUTE_UNUSED can be used, please do. :-)<br><div><br></div><div>ありがとうございます。</div><div>-bw</div><div><br><div><div>On Oct 19, 2010, at 7:33 PM, NAKAMURA Takumi wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Bill san, Jim san,<br><br>Thank you to give me comments.<br>I am sorry I remembered only the fixup in lib/System/RWMutex.cpp@110667,<br>and I commited similarly.<br><br>I think it would be better to take Bill's way. May I fix up 2 files<br>with attached patch?<br><br>...Takumi<br><br>ps. I can still see some points with grep -nri '(void)[A-Z][0-9A-Z]*;'<br>| fgrep -iv warning<br><br><br>2010/10/20 Bill Wendling <<a href="mailto:wendling@apple.com">wendling@apple.com</a>>:<br><blockquote type="cite">Or better yet, use the ATTRIBUTE_UNUSED attribute in<br></blockquote><blockquote type="cite">llvm/Support/Compiler.h.<br></blockquote><blockquote type="cite">-bw<br></blockquote><blockquote type="cite">On Oct 19, 2010, at 9:16 AM, Jim Grosbach wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Can you add a comment saying why that line is necessary? Otherwise some well<br></blockquote><blockquote type="cite">meaning person may remove the "unusued" statement.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-Jim<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On Oct 18, 2010, at 6:22 PM, NAKAMURA Takumi wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Author: chapuni<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Date: Mon Oct 18 20:22:01 2010<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">New Revision: 116785<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=116785&view=rev">http://llvm.org/viewvc/llvm-project?rev=116785&view=rev</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">lib/System/Win32/ThreadLocal.inc: Suppress "unused" warning on -Asserts.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> llvm/trunk/lib/System/Win32/ThreadLocal.inc<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified: llvm/trunk/lib/System/Win32/ThreadLocal.inc<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL:<br></blockquote><blockquote type="cite"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Win32/ThreadLocal.inc?rev=116785&r1=116784&r2=116785&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Win32/ThreadLocal.inc?rev=116785&r1=116784&r2=116785&view=diff</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">--- llvm/trunk/lib/System/Win32/ThreadLocal.inc (original)<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+++ llvm/trunk/lib/System/Win32/ThreadLocal.inc Mon Oct 18 20:22:01 2010<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">@@ -44,6 +44,7 @@<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> DWORD* tls = static_cast<DWORD*>(data);<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> int errorcode = TlsSetValue(*tls, const_cast<void*>(d));<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"> assert(errorcode != 0);<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">+ (void)errorcode;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">}<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">void ThreadLocalImpl::removeInstance() {<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">llvm-commits mailing list<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">llvm-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><span><unused-var.diff.txt></span></div></blockquote></div><br></div></div></body></html>