<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div></div><div><br><div><div>On Sep 14, 2010, at 4:49 PM, Cameron Esfahani wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Okay, here's a version which reverts the listed change below. I'm using the TargetFrameInfo to determine how far we are from the caller allocated portion of the stack.<div><br></div><div>I've also written a test case to verify that the non-var arg, more than 4 parameter, function calls still work.<br><div><br></div><div>Hopefully this should address all the remaining issues for the Windows 64 var args patch.</div><div><br></div><div></div></div></div><span><llvm_va.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div></div><div><br><div><div>On Sep 2, 2010, at 8:42 PM, Cameron Esfahani wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">This is required for the var arg support. Without this change, there's no way to know how far the home register space allocated by the caller is from the top of the stack. Any fixed object created via MFI is put at it's offset after the frame info stuff is calculated. So, if you wanted to put something into the caller's frame, it's pretty difficult.<br><br>On Sep 2, 2010, at 4:13 PM, Anton Korobeynikov wrote:<br><br><blockquote type="cite">Hello, Cameron<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Here's the corresponding llvm changes to support the Win64 ABI version of var args. With a test case!<br></blockquote></blockquote><blockquote type="cite">This hunk seems to be unrelated to the patch and in wrong in general:<br></blockquote><blockquote type="cite">- (Subtarget.isTargetWin64() ? -40 :<br></blockquote><blockquote type="cite">- (Subtarget.is64Bit() ? -8 : -4))),<br></blockquote><blockquote type="cite">+ (Subtarget.is64Bit() ? -8 : -4)),<br></blockquote><blockquote type="cite">Why do you need it?<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">--<span class="Apple-converted-space"> </span><br></blockquote><blockquote type="cite">With best regards, Anton Korobeynikov<br></blockquote><blockquote type="cite">Faculty of Mathematics and Mechanics, Saint Petersburg State University<br></blockquote><br>Cameron Esfahani<br><a href="mailto:dirty@apple.com">dirty@apple.com</a><br><br>"You only live once, and the way I live, once is enough"<br><br>Frank Sinatra<br></blockquote></div><br><div>
<div style="font-size: 12px; ">Cameron Esfahani</div><div style="font-size: 12px; "><a href="mailto:dirty@apple.com">dirty@apple.com</a></div><div style="font-size: 12px; "><br class="khtml-block-placeholder"></div><div style="font-size: 12px; ">"Americans are very skilled at creating a custom meaning from something that's mass-produced."</div><div style="font-size: 12px; "><br class="khtml-block-placeholder"></div><div style="font-size: 12px; ">Ann Powers</div><span class="Apple-style-span" style="font-size: 12px; "><br class="Apple-interchange-newline"></span>
</div>
<br></div></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><div>Cameron Esfahani</div><div><a href="mailto:dirty@apple.com">dirty@apple.com</a></div><div><br class="khtml-block-placeholder"></div><div>"You only live once, and the way I live, once is enough"</div><div><br class="khtml-block-placeholder"></div><div>Frank Sinatra</div><div><br class="khtml-block-placeholder"></div><br class="Apple-interchange-newline"></span>
</div>
<br></div></body></html>