<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 6, 2010, at 2:03 PM, Nick Lewycky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Tue, Jul 6, 2010 at 1:54 PM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div style="word-wrap: break-word;"><div><div class="im"><div>On Jul 6, 2010, at 1:50 PM, Nick Lewycky wrote:</div><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>> * a new pass named HaltingAttr is added to mark up functions with the halting attribute. If necessary, it queries SCEV for an upper bound on the loop trip count. It is not an SCC pass.<br>
<br>
</div>Why can't this be done in the existing bottom-up pass for inferring this?<br></blockquote><div><br>SCC passes can't depend on FunctionPasses like LoopInfo and SCEV.<br></div></div></blockquote><div><br></div>
</div><div>I think that having the existing SCC pass propagate the bit from callee to caller where possible makes sense. How does a function pass know it is going to visit a callee before a caller? For a function to be "halting" all called functions also have to be known to halt.</div>
</div></div></blockquote><div><br>I tried that. The problem with splitting it into two passes is that the pass doing the local analysis can't safely mark any non-leaf function since the callees haven't been tagged 'halting' yet, and the SCC pass can't mark anything halting since it doesn't have a local analysis to check for loops inside the function itself. Hence they need to be merged.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div style="word-wrap: break-word;"><div><div class="im"><blockquote type="cite"><div class="gmail_quote">
<div>Also, we can't make use of SCC anyhow because two functions that halt locally but also call each other aren't necessarily halting; they could recurse infinitely. However, having the CallGraphNode* is useful to avoid a linear scan looking for CallInst's as it already has the list.<br>
</div></div></blockquote><div><br></div></div><div>Are you saying that you really have to give up on any non-leaf function?</div></div></div></blockquote><div><br>It's still a bottom-up walk of the call graph, it's just that we can't take advantage of SCCs to infer the property.<br></div></div></blockquote><div><br></div><div>Is this still useful in practice, or is this realistically something that just gets marked on intrinsics?</div><div><br></div><div>Also, are potentially blocking operations (mutex lock, 'write', etc) considered to be halting?</div><div><br></div><blockquote type="cite"><div class="gmail_quote"><div>
</div><blockquote class="gmail_quote" style="border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap: break-word;"><div><div class="im"><blockquote type="cite"><div class="gmail_quote">
<div>Finally, my patch was missing the part where I actually add HaltingAttr to the list of standard passes. I need to think more about where I want to schedule this; I really want it after the loop optimizations but before the inliner makes its decision. A CGSCCPass would be perfect, were it not for the inability to depend on LoopInfo and SCEV.<br>
</div></div></blockquote><div><br></div></div><div>At the high level, this is the part I'm most concerned with.</div></div></div></blockquote><div><br>Likewise, I hadn't realized how bad it was before sending out the original patch. Once I figure this out I'll send out an patch update.<br>
<br>It's possible that there's no good solution here and we just plain need to run the -haltingattr pass before the inliner and loop passes. That would be sad, but not the end of the world. We could deal with the cause of that (undesirable pass manager constraints) separately. Since CallGraph is in lib/Analysis, it's yet another hard problem.<br></div></div></blockquote></div><br><div>The other thing that concerns me is that there is a lot of cases that really can't be handled. Iterating over an std::map or another node-based container can't be handled with this. If you have some sort of front-end attributes (like the halting attribute you proposed for clang) or other language semantics that would be useful, then it makes sense.</div><div><br></div><div>Some thoughts on the patch:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+++ lib/VMCore/Instruction.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">@@ -410,10 +424,14 @@</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> return false;</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> case Call:</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ // A user-defined function could have undefined behavior, even if it's</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ // readnone nounwind and halting.</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ if (const IntrinsicInst *II = dyn_cast<IntrinsicInst>(this)) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ // FIXME: We should special-case some more intrinsics (bswap,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ // overflow-checking arithmetic, etc.)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ return II->doesNotAccessMemory() && II->doesNotThrow() && II->isHalting();</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ return false;</div></div><div><br></div><div>I don't understand the fixme here.</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+++ lib/Transforms/Scalar/Sink.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">@@ -234,7 +234,7 @@</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> if (SuccToSinkTo->getUniquePredecessor() != ParentBlock) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> // We cannot sink a load across a critical edge - there may be stores in</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> // other code paths.</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">- if (!Inst->isSafeToSpeculativelyExecute()) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; ">+ if (Inst->mayReadFromMemory()) {</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> DEBUG(dbgs() << " *** PUNTING: Wont sink load along critical edge.\n");</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> return false;</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "> }</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 13px/normal Inconsolata; "><font class="Apple-style-span" face="Helvetica"><span class="Apple-style-span" style="font-size: medium;"><font class="Apple-style-span" face="Inconsolata" size="3"><span class="Apple-style-span" style="font-size: 13px;"><br></span></font></span></font></div></div><div>Why is this safe?</div><div><br></div><div>I really don't like the halting pass being a modulepass. This isn't going to fit into the compiler well. It either needs to be a cgsccpass, a function pass, or a combination of the two.</div><div><br></div><div>-Chris</div></body></html>