<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">This is still failing. Is there a fix in sight?<div><br><div><div>On Jun 25, 2010, at 11:42 AMPDT, Devang Patel wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Is it possible for some to send me generated <span class="Apple-style-span" style="font-family: 'Courier New', courier, monotype; white-space: pre; ">2010-06-24-DbgInlinedFnParameter.c.tmp.s ?</span><div><div><div><br></div><div>Thanks,</div><div>-</div><div>Devang</div><div>On Jun 25, 2010, at 7:21 AM, Daniel Dunbar wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi Devang,<br><br>This test is failing on a two-stage llvm-gcc bootstrap. See here:<br> <a href="http://google1.osuosl.org:8011/builders/llvm-gcc-i686-darwin10-selfhost/builds/5139/steps/test.llvm.stage2/logs/2010-06-24-dbginlinedfnparameter.c">http://google1.osuosl.org:8011/builders/llvm-gcc-i686-darwin10-selfhost/builds/5139/steps/test.llvm.stage2/logs/2010-06-24-dbginlinedfnparameter.c</a><br><br> - Daniel<br><br>On Thu, Jun 24, 2010 at 2:51 PM, Devang Patel <<a href="mailto:dpatel@apple.com">dpatel@apple.com</a>> wrote:<br><blockquote type="cite">Author: dpatel<br></blockquote><blockquote type="cite">Date: Thu Jun 24 16:51:19 2010<br></blockquote><blockquote type="cite">New Revision: 106792<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=106792&view=rev">http://llvm.org/viewvc/llvm-project?rev=106792&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">DBG_VALUE machine instruction pointing to undefined register for a variable justify a separate scope if the variable is inlined function's argument.<br></blockquote><blockquote type="cite">Radar 8122864.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Added:<br></blockquote><blockquote type="cite"> llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c<br></blockquote><blockquote type="cite">Modified:<br></blockquote><blockquote type="cite"> llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=106792&r1=106791&r2=106792&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=106792&r1=106791&r2=106792&view=diff</a><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite">--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br></blockquote><blockquote type="cite">+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Thu Jun 24 16:51:19 2010<br></blockquote><blockquote type="cite">@@ -2390,8 +2390,6 @@<br></blockquote><blockquote type="cite"> static bool hasValidLocation(LLVMContext &Ctx,<br></blockquote><blockquote type="cite"> const MachineInstr *MInsn,<br></blockquote><blockquote type="cite"> const MDNode *&Scope, const MDNode *&InlinedAt) {<br></blockquote><blockquote type="cite">- if (MInsn->isDebugValue())<br></blockquote><blockquote type="cite">- return false;<br></blockquote><blockquote type="cite"> DebugLoc DL = MInsn->getDebugLoc();<br></blockquote><blockquote type="cite"> if (DL.isUnknown()) return false;<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">@@ -2655,7 +2653,6 @@<br></blockquote><blockquote type="cite"> assert (MI->getNumOperands() > 1 && "Invalid machine instruction!");<br></blockquote><blockquote type="cite"> DIVariable DV(MI->getOperand(MI->getNumOperands() - 1).getMetadata());<br></blockquote><blockquote type="cite"> if (!DV.Verify()) continue;<br></blockquote><blockquote type="cite">- if (isDbgValueInUndefinedReg(MI)) continue;<br></blockquote><blockquote type="cite"> // If DBG_VALUE is for a local variable then it needs a label.<br></blockquote><blockquote type="cite"> if (DV.getTag() != dwarf::DW_TAG_arg_variable)<br></blockquote><blockquote type="cite"> InsnNeedsLabel.insert(MI);<br></blockquote><blockquote type="cite">@@ -2663,7 +2660,7 @@<br></blockquote><blockquote type="cite"> else if (!DISubprogram(DV.getContext()).describes(MF->getFunction()))<br></blockquote><blockquote type="cite"> InsnNeedsLabel.insert(MI);<br></blockquote><blockquote type="cite"> // DBG_VALUE indicating argument location change needs a label.<br></blockquote><blockquote type="cite">- else if (!ProcessedArgs.insert(DV))<br></blockquote><blockquote type="cite">+ else if (isDbgValueInUndefinedReg(MI) == false && !ProcessedArgs.insert(DV))<br></blockquote><blockquote type="cite"> InsnNeedsLabel.insert(MI);<br></blockquote><blockquote type="cite"> } else {<br></blockquote><blockquote type="cite"> // If location is unknown then instruction needs a location only if<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Added: llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c<br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c?rev=106792&view=auto">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c?rev=106792&view=auto</a><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite">--- llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c (added)<br></blockquote><blockquote type="cite">+++ llvm/trunk/test/FrontendC/2010-06-24-DbgInlinedFnParameter.c Thu Jun 24 16:51:19 2010<br></blockquote><blockquote type="cite">@@ -0,0 +1,15 @@<br></blockquote><blockquote type="cite">+// RUN: %llvmgcc -S -O2 -g %s -o - | llc -O2 -o %t.s<br></blockquote><blockquote type="cite">+// RUN: grep "# DW_TAG_formal_parameter" %t.s | count 4<br></blockquote><blockquote type="cite">+// Radar 8122864<br></blockquote><blockquote type="cite">+static int foo(int a, int j) {<br></blockquote><blockquote type="cite">+ int k = 0;<br></blockquote><blockquote type="cite">+ if (a)<br></blockquote><blockquote type="cite">+ k = a + j;<br></blockquote><blockquote type="cite">+ else<br></blockquote><blockquote type="cite">+ k = j;<br></blockquote><blockquote type="cite">+ return k;<br></blockquote><blockquote type="cite">+}<br></blockquote><blockquote type="cite">+int bar(int o, int p) {<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ return foo(o, p);<br></blockquote><blockquote type="cite">+}<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">llvm-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><blockquote type="cite"><br></blockquote></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>