<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 15, 2010, at 1:55 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Jan 12, 2010, at 10:34 AM, Devang Patel wrote:<br><blockquote type="cite">Author: dpatel<br></blockquote><blockquote type="cite">Date: Tue Jan 12 12:34:06 2010<br></blockquote><blockquote type="cite">New Revision: 93247<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=93247&view=rev">http://llvm.org/viewvc/llvm-project?rev=93247&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">Use ilist_tratis to autoinsert and remove NamedMDNode from MDSymbolTable.<br></blockquote><br>Great,<br><br><blockquote type="cite">+++ llvm/trunk/include/llvm/ValueSymbolTable.h Tue Jan 12 12:34:06 2010<br></blockquote><blockquote type="cite">@@ -17,6 +17,7 @@<br></blockquote><blockquote type="cite">#include "llvm/Value.h"<br></blockquote><blockquote type="cite">#include "llvm/ADT/StringMap.h"<br></blockquote><blockquote type="cite">#include "llvm/System/DataTypes.h"<br></blockquote><blockquote type="cite">+#include "llvm/ADT/ilist_node.h"<br></blockquote><br>You shouldn't need this #include.<br></div></blockquote><div><br></div>Done.</div><div><br><blockquote type="cite"><div><br><blockquote type="cite">+++ llvm/trunk/lib/VMCore/Metadata.cpp Tue Jan 12 12:34:06 2010<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">/// setName - Set the name of this named metadata.<br></blockquote><blockquote type="cite">void NamedMDNode::setName(StringRef N) {<br></blockquote><blockquote type="cite">+ assert (!N.empty() && "Invalid named metadata name!");<br></blockquote><blockquote type="cite">+ Name = N.str();<br></blockquote><blockquote type="cite">+ if (Parent)<br></blockquote><blockquote type="cite">+ Parent->getMDSymbolTable().insert(N, this);<br></blockquote><blockquote type="cite">}<br></blockquote><br>Doesn't this need to remove the old name from the symbol table before setting the new name?<br><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><br></div><div>Done.</div><div>-</div><div>Devang</div></body></html>