<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks good. <div><br></div><div><span class="Apple-style-span" style="font-family: Times; "><pre style="word-wrap: break-word; white-space: pre-wrap; ">+ static void onDeleted(ExecutionEngineState *EES, const GlobalValue *Old);</pre></span><div>It seems like "onDelete" is a better name? It's more consistent with onRAUW.</div><div><br></div><div><span class="Apple-style-span" style="font-family: Times; "><pre style="word-wrap: break-word; white-space: pre-wrap; "><span class="Apple-style-span" style="font-family: Times; white-space: normal; "><pre style="word-wrap: break-word; white-space: pre-wrap; ">+ {
+ raw_string_ostream os(errMsg);
+ Error.Print("", os);
+ }</pre></span><div><br></div></pre></span><div>Not important. But why the { }?</div><div><br></div><div>Thanks,</div><div><br></div><div>Evan</div><div><br></div><div><div>On Oct 22, 2009, at 3:43 PM, <a href="mailto:jyasskin@gmail.com">jyasskin@gmail.com</a> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Evan, could you take a look?<br><br>New patch at<br><a href="http://codereview.appspot.com/download/issue133043_3001.diff">http://codereview.appspot.com/download/issue133043_3001.diff</a><br><br>http://codereview.appspot.com/133043<br></div></blockquote></div><br></div></div></body></html>