<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Aug 31, 2009, at 9:33 AM, Duncan Sands wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>if the place that outputs the data already has enough info to get the<br>format right, then doesn't that mean that the getPreferredLSDADataFormat<br>target hook is redundant? It could presumably be implemented as a<br>utility in DwarfException.cpp, and be driven by the same target info<br>that is driving LSDA output.<br></div></blockquote><div><font class="Apple-style-span" color="#000000">[...]<br></font></div><blockquote type="cite"><div>Sure, it should all be driven by a logical and orthogonal set of<br>target information. That's why I don't see the point of introducing<br>a new target hook (getPreferredLSDADataFormat) which is not orthogonal<br>at all, since it can apparently be calculated from existing target<br>settings...<br><br></div></blockquote><div><div>Sure. I suppose what I'm saying here is that I don't know the orthogonal set of conditions which need to be met to determine the data format at this point. I don't see anything in the LSDA output code which indicates that it's following orthogonal conditions. It's just outputting stuff.</div><div><br></div></div><blockquote type="cite"><div><blockquote type="cite">It would probably be better to simply use the actual byte size of the <br></blockquote><blockquote type="cite">pointer. Though I'm not at all sure how that would work on machines with <br></blockquote><blockquote type="cite">ptrs > 8 bytes.<br></blockquote><br>I guess 16 bit machines are more likely :) Anyway, the only real point<br>I want to make is that rather than having stuff like "if (4 bytes) then<br>x; else (y)" all over the place, it would be neater to have methods that<br>work without any assumptions on pointer sizes, even if no such machines<br>exist.<br><br></div></blockquote></div>'Twould be a grand world if that were so.<div><br></div><div>-bw</div><div><br></div></body></html>