any issue, the assert should change to:<div><div>void ThreadLocalImpl::setInstance(const void* d){</div><div> DWORD* tls = static_cast<DWORD*>(data);</div><div> int errorcode = TlsSetValue(*tls, const_cast<void*>(d));</div>
<div> assert(errorcode != 0); <====</div><div>}</div><div><br></div><div>From MSDN:</div><div><span class="Apple-style-span" style="font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 11px; line-height: 15px; "><h3 style="font-size: 12px; font-weight: 700; ">
Return Value</h3><p style="margin-top: 0px; margin-right: 0px; margin-bottom: 10px; margin-left: 0px; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; ">If the function succeeds, the return value is nonzero.</p>
<p style="margin-top: 0px; margin-right: 0px; margin-bottom: 10px; margin-left: 0px; padding-top: 0px; padding-right: 0px; padding-bottom: 0px; padding-left: 0px; ">If the function fails, the return value is zero. To get extended error information, call<a id="ctl00_MTContentSelector1_mainContentContainer_ctl03" onclick="javascript:Track('ctl00_MTContentSelector1_mainContentContainer_ctl00|ctl00_MTContentSelector1_mainContentContainer_ctl03',this);" href="http://msdn.microsoft.com/en-us/library/ms679360(VS.85).aspx" style="text-decoration: none; color: rgb(0, 51, 204); "><strong>GetLastError</strong></a>.</p>
</span></div><div><br></div><br><div class="gmail_quote">On Fri, Jun 26, 2009 at 8:48 AM, Howard Su <span dir="ltr"><<a href="mailto:howard0su@gmail.com">howard0su@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>c:\llvm\lib\system\Win32/ThreadLocal.inc(45) : error C2664: 'TlsSetValue' : cann</div><div>ot convert parameter 2 from 'const void *' to 'LPVOID'</div><div> Conversion loses qualifiers</div>
<div><br></div><div>It is safe to add a force cast here.</div><div><div></div><div class="h5"><br><div class="gmail_quote">On Fri, Jun 26, 2009 at 5:58 AM, Owen Anderson <span dir="ltr"><<a href="mailto:resistor@mac.com" target="_blank">resistor@mac.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: resistor<br>
Date: Thu Jun 25 16:58:01 2009<br>
New Revision: 74209<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=74209&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=74209&view=rev</a><br>
Log:<br>
Add a class for supporting platform independent thread-local storage.<br>
<br>
Windows people, please double-check/patch this.<br>
<br>
Added:<br>
llvm/trunk/include/llvm/System/ThreadLocal.h<br>
llvm/trunk/lib/System/ThreadLocal.cpp<br>
llvm/trunk/lib/System/Unix/ThreadLocal.inc<br>
llvm/trunk/lib/System/Win32/ThreadLocal.inc<br>
<br>
Added: llvm/trunk/include/llvm/System/ThreadLocal.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/System/ThreadLocal.h?rev=74209&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/System/ThreadLocal.h?rev=74209&view=auto</a><br>
<br>
==============================================================================<br>
--- llvm/trunk/include/llvm/System/ThreadLocal.h (added)<br>
+++ llvm/trunk/include/llvm/System/ThreadLocal.h Thu Jun 25 16:58:01 2009<br>
@@ -0,0 +1,41 @@<br>
+//===- llvm/System/ThreadLocal.h - Thread Local Data ------------*- C++ -*-===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+//<br>
+// This file declares the llvm::sys::ThreadLocal class.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#ifndef LLVM_SYSTEM_THREAD_LOCAL_H<br>
+#define LLVM_SYSTEM_THREAD_LOCAL_H<br>
+<br>
+#include "llvm/System/Threading.h"<br>
+#include <cassert><br>
+<br>
+namespace llvm {<br>
+ namespace sys {<br>
+ class ThreadLocalImpl {<br>
+ void* data;<br>
+ public:<br>
+ ThreadLocalImpl();<br>
+ virtual ~ThreadLocalImpl();<br>
+ void setInstance(void* d);<br>
+ void* getInstance();<br>
+ };<br>
+<br>
+ template<class T><br>
+ class ThreadLocal : public ThreadLocalImpl {<br>
+ public:<br>
+ ThreadLocal() : ThreadLocalImpl() { }<br>
+ T* get() { return static_cast<T*>(getInstance()); }<br>
+ void set(T* d) { setInstance(d); }<br>
+ };<br>
+ }<br>
+}<br>
+<br>
+#endif<br>
<br>
Added: llvm/trunk/lib/System/ThreadLocal.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/ThreadLocal.cpp?rev=74209&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/ThreadLocal.cpp?rev=74209&view=auto</a><br>
<br>
==============================================================================<br>
--- llvm/trunk/lib/System/ThreadLocal.cpp (added)<br>
+++ llvm/trunk/lib/System/ThreadLocal.cpp Thu Jun 25 16:58:01 2009<br>
@@ -0,0 +1,77 @@<br>
+//===- ThreadLocal.cpp - Thread Local Data ----------------------*- C++ -*-===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+//<br>
+// This file implements the llvm::sys::ThreadLocal class.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#include "llvm/Config/config.h"<br>
+#include "llvm/System/ThreadLocal.h"<br>
+<br>
+//===----------------------------------------------------------------------===//<br>
+//=== WARNING: Implementation here must contain only TRULY operating system<br>
+//=== independent code.<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#if !defined(ENABLE_THREADS) || ENABLE_THREADS == 0<br>
+// Define all methods as no-ops if threading is explicitly disabled<br>
+namespace llvm {<br>
+using namespace sys;<br>
+ThreadLocalImpl::ThreadLocalImpl() { }<br>
+ThreadLocalImpl::~ThreadLocalImpl() { }<br>
+void ThreadLocalImpl::setInstance(void* d) { data = d; }<br>
+void* ThreadLocalImpl::getInstance() { return data; }<br>
+}<br>
+#else<br>
+<br>
+#if defined(HAVE_PTHREAD_H) && defined(HAVE_PTHREAD_MUTEX_LOCK)<br>
+<br>
+#include <cassert><br>
+#include <pthread.h><br>
+#include <stdlib.h><br>
+<br>
+namespace llvm {<br>
+using namespace sys;<br>
+<br>
+ThreadLocalImpl::ThreadLocalImpl() : data(0) {<br>
+ pthread_key_t* key = new pthread_key_t;<br>
+ int errorcode = pthread_key_create(key, NULL);<br>
+ assert(errorcode == 0);<br>
+ data = key;<br>
+}<br>
+<br>
+ThreadLocalImpl::~ThreadLocalImpl() {<br>
+ pthread_key_t* key = static_cast<pthread_key_t*>(data);<br>
+ int errorcode = pthread_key_delete(*key);<br>
+ assert(errorcode = 0);<br>
+ delete key;<br>
+}<br>
+<br>
+void ThreadLocalImpl::setInstance(void* d) {<br>
+ pthread_key_t* key = static_cast<pthread_key_t*>(data);<br>
+ int errorcode = pthread_setspecific(*key, d);<br>
+ assert(errorcode == 0);<br>
+}<br>
+<br>
+void* ThreadLocalImpl::getInstance() {<br>
+ pthread_key_t* key = static_cast<pthread_key_t*>(data);<br>
+ return pthread_getspecific(*key);<br>
+}<br>
+<br>
+}<br>
+<br>
+#elif defined(LLVM_ON_UNIX)<br>
+#include "Unix/ThreadLocal.inc"<br>
+#elif defined( LLVM_ON_WIN32)<br>
+#include "Win32/ThreadLocal.inc"<br>
+#else<br>
+#warning Neither LLVM_ON_UNIX nor LLVM_ON_WIN32 was set in System/ThreadLocal.cpp<br>
+#endif<br>
+#endif<br>
+<br>
<br>
Added: llvm/trunk/lib/System/Unix/ThreadLocal.inc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Unix/ThreadLocal.inc?rev=74209&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Unix/ThreadLocal.inc?rev=74209&view=auto</a><br>
<br>
==============================================================================<br>
--- llvm/trunk/lib/System/Unix/ThreadLocal.inc (added)<br>
+++ llvm/trunk/lib/System/Unix/ThreadLocal.inc Thu Jun 25 16:58:01 2009<br>
@@ -0,0 +1,25 @@<br>
+//=== llvm/System/Unix/ThreadLocal.inc - Unix Thread Local Data -*- C++ -*-===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+//<br>
+// This file implements the Unix specific (non-pthread) ThreadLocal class.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+//===----------------------------------------------------------------------===//<br>
+//=== WARNING: Implementation here must contain only generic UNIX code that<br>
+//=== is guaranteed to work on *all* UNIX variants.<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+namespace llvm {<br>
+using namespace sys;<br>
+ThreadLocalImpl::ThreadLocalImpl() { }<br>
+ThreadLocalImpl::~ThreadLocalImpl() { }<br>
+void ThreadLocalImpl::setInstance(void* d) { data = d; }<br>
+void* ThreadLocalImpl::getInstance() { return data; }<br>
+}<br>
\ No newline at end of file<br>
<br>
Added: llvm/trunk/lib/System/Win32/ThreadLocal.inc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Win32/ThreadLocal.inc?rev=74209&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Win32/ThreadLocal.inc?rev=74209&view=auto</a><br>
<br>
==============================================================================<br>
--- llvm/trunk/lib/System/Win32/ThreadLocal.inc (added)<br>
+++ llvm/trunk/lib/System/Win32/ThreadLocal.inc Thu Jun 25 16:58:01 2009<br>
@@ -0,0 +1,49 @@<br>
+//= llvm/System/Win32/ThreadLocal.inc - Win32 Thread Local Data -*- C++ -*-===//<br>
+//<br>
+// The LLVM Compiler Infrastructure<br>
+//<br>
+// This file is distributed under the University of Illinois Open Source<br>
+// License. See LICENSE.TXT for details.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+//<br>
+// This file implements the Win32 specific (non-pthread) ThreadLocal class.<br>
+//<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+//===----------------------------------------------------------------------===//<br>
+//=== WARNING: Implementation here must contain only generic Win32 code that<br>
+//=== is guaranteed to work on *all* Win32 variants.<br>
+//===----------------------------------------------------------------------===//<br>
+<br>
+#include "Win32.h"<br>
+#include "llvm/System/ThreadLocal.h"<br>
+<br>
+namespace llvm {<br>
+using namespace sys;<br>
+<br>
+ThreadLocalImpl::ThreadLocalImpl() {<br>
+ DWORD* tls = new DWORD;<br>
+ *tls = TlsAlloc();<br>
+ assert(*tls != TLS_OUT_OF_INDEXES);<br>
+ data = tls;<br>
+}<br>
+<br>
+ThreadLocalImpl::~ThreadLocalImpl() {<br>
+ DWORD* tls = static_cast<DWORD*>(data);<br>
+ TlsFree(*tls);<br>
+ delete tls;<br>
+}<br>
+<br>
+void* ThreadLocalImpl::getInstance() {<br>
+ DWORD* tls = static_cast<DWORD*>(data);<br>
+ return TlsGetValue(*tls);<br>
+}<br>
+<br>
+void ThreadLocalImpl::setInstance(void* d){<br>
+ DWORD* tls = static_cast<DWORD*>(data);<br>
+ int errorcode = TlsSetValue(*tls, d);<br>
+ assert(errorcode == 0);<br>
+}<br>
+<br>
+}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><br></div></div>-- <br><font color="#888888">-Howard<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>-Howard<br>
</div>