<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 19, 2009, at 10:27 AM, Bob Wilson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>I've committed the patch. It worked fine on my tester, but one thing <br>I noticed is that the file names submitted to the database before this <br>patch had an extra slash in the paths, e.g., "Release//lib/ <br>libLLVMCore.a". Now that extra slash is gone. The nightly tester <br>website will think they are different files -- it's not very smart -- <br>so the changes in file size will not be reported between yesterday and <br>today.<br><br></div></blockquote><div><br></div><div>Actually it is pretty important. I'm pretty sure this will break past results. So look at the graphs.. you will only see so far back. I know its true with the new nightly tester database since we have a table with filenames.</div><div><br></div><div>-Tanya</div><br><blockquote type="cite"><div>On Jun 18, 2009, at 11:43 AM, Bob Wilson wrote:<br><br><blockquote type="cite">Nice cleanup. Thanks, Benjamin. I'm going to try it out with my<br></blockquote><blockquote type="cite">nightly tester. If everything goes well, I'll commit your patch<br></blockquote><blockquote type="cite">tomorrow.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On Jun 18, 2009, at 4:31 AM, Benjamin Kramer wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">Sorry, but seeing this ugly perl code almost made my cry (not your<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">fault though). So I decided to port it to File::Find which is part<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">of perl's standard library.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">This gives us some advantages:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">1. portability: File::Find works even on windows ;)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">2. performance: the new code is >100 times faster on my machine. The<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">slowdown is probably caused by backtracking in the old regex<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">3. cleanup: there were lots of duplicated code<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><nightlyfind.patch><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">llvm-commits mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">llvm-commits mailing list<br></blockquote><blockquote type="cite"><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br></blockquote><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></body></html>