<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Also, you didn't commit a test case for this.<div><br></div><div>Evan</div><div><br><div><div>On Jun 3, 2009, at 3:20 PM, Evan Cheng wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Stuart, this doesn't look right. The source in the pattern and the instruction are of different register classes. One is FR64, the other is VR128.<div><br></div><div>Evan</div><div><br><div><div>On Jun 3, 2009, at 2:39 PM, Stuart Hastings wrote:</div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font><br>==============================================================================<br>--- llvm/trunk/lib/Target/X86/X86InstrMMX.td (original)<br>+++ llvm/trunk/lib/Target/X86/X86InstrMMX.td Wed Jun 3 16:39:14 2009<br>@@ -680,6 +680,8 @@<br> def : Pat<(v8i8 (bitconvert (i64 (vector_extract (v2i64 VR128:$src),<br> (iPTR 0))))),<br> (v8i8 (MMX_MOVDQ2Qrr VR128:$src))>;<br>+def : Pat<(v2i32 (bitconvert (f64 FR64:$src))),<br>+ (v2i32 (MMX_MOVDQ2Qrr VR128:$src))>;<br><br> // CMOV* - Used to implement the SELECT DAG operation. Expanded by the<br> // scheduler into a branch sequence.<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>