<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 24, 2009, at 2:45 PM, Misha Brukman wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Tue, Mar 24, 2009 at 2:15 PM, Chris Lattner <span dir="ltr"><<a href="mailto:sabre@nondot.org">sabre@nondot.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> ==============================================================================<br> --- llvm/trunk/test/Transforms/InstCombine/shift.ll (original)<br> +++ llvm/trunk/test/Transforms/InstCombine/shift.ll Tue Mar 24 13:15:30 2009<br> @@ -206,4 +206,11 @@<br> %D = shl i32 %C, 1 ; <i32> [#uses=1]<br> ret i32 %D<br> }<br> +<br> +<br> +define i1 @test27(i32 %x) nounwind {<br> + %y = lshr i32 %x, 3<br> + %z = trunc i32 %y to i1<br> + ret i1 %z<br> +}</blockquote><div><br>This would work great as a unittest. Just sayin'.<br></div></div></blockquote><br></div><div>Why would it be better as a unit test?</div><div><br></div><div>-Chris</div><br></body></html>