<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Feb 17, 2009, at 8:52 PM, Evan Cheng wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Feb 17, 2009, at 7:48 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Feb 17, 2009, at 6:19 PM, Evan Cheng wrote:<br><br><blockquote type="cite">Author: evancheng<br></blockquote><blockquote type="cite">Date: Tue Feb 17 20:19:52 2009<br></blockquote><blockquote type="cite">New Revision: 64877<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=64877&view=rev">http://llvm.org/viewvc/llvm-project?rev=64877&view=rev</a><br></blockquote><blockquote type="cite">Log:<br></blockquote><blockquote type="cite">GV with null value initializer shouldn't go to BSS if it's meant for <br></blockquote><blockquote type="cite">a mergeable strings section. Currently it only checks for Darwin. <br></blockquote><blockquote type="cite">Someone else please check if it should apply to other targets as well.<br></blockquote><br>Evan, this seems like the wrong fix. What *requires* an empty string <br>to go into the cstring section? If there is some semantics that <br>require it, then whatever produces the llvm global should set the <br>section of the global to the cstring section explicitly.</div></blockquote><div><br></div>I don't see why this is wrong/ Per revision <span class="Apple-style-span" style="font-family: -webkit-monospace; font-size: 11px; ">63142,<span class="Apple-style-span" style="font-family: Helvetica; font-size: 12px; ">target asm info has already decided this particular GV should go into cstring. But the asm printer then decided to put it in BSS (which means it cannot be coalesced) because the initializer is empty. This patch makes sure asm printer doesn't try to out smart itself.</span></span></div><div></div></div></blockquote></div><br><div>Why is this important? </div><div><br></div><div>-Chris</div></body></html>