2009/1/5 Misha Brukman <span dir="ltr"><<a href="mailto:brukman@gmail.com">brukman@gmail.com</a>></span><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">2009/1/5 John Criswell <span dir="ltr"><<a href="mailto:criswell@cs.uiuc.edu" target="_blank">criswell@cs.uiuc.edu</a>></span><br></div></div><div class="gmail_quote"><div><div></div>
<div class="Wj3C7c"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Misha Brukman wrote:<br>
> 2009/1/5 John Criswell <<a href="mailto:criswell@cs.uiuc.edu" target="_blank">criswell@cs.uiuc.edu</a><mailto:<a href="mailto:criswell@cs.uiuc.edu" target="_blank">criswell@cs.uiuc.edu</a>>><br>
<div>> 1) Can you move the copyright/license information to a LICENSE.TXT file<br>
> and add an entry in llvm/LICENSE.TXT? This is the established convention<br>
> for third party licenses and makes it easier to find what code has<br>
> additional licenses.<br>
><br>
> It was already listed in llvm/LICENSE.TXT and referred to the file COPYING in this directory, but since you insist, I renamed it to LICENSE.TXT .<br>
><br>
</div>Sorry. I didn't notice the new text in the top level LICENSE.TXT file.<br>
<br>
Thanks for renaming the COPYING file.<br>
<div><br>
> 2) The code doesn't compile on my Linux machine. I get the following<br>
</div>> errors with g++ 4.1.2.<<a href="http://4.1.2" target="_blank">http://4.1.2</a>.>:<br>
<div>><br>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-port.h:327:21:<br>
> warning: tr1/tuple: No such file or directory<br>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:<br>
> error: 'tr1' is not a member of 'std'<br>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:<br>
> error: 'tr1' is not a member of 'std'<br>
> /home/vadve/criswell/src/llvm22/utils/unittest/googletest/include/gtest/internal/gtest-param-util-generated.h:2670:<br>
> error: template argument 1 is invalid<br>
><br>
> Do you know what the problem might be?<br>
><br>
> Hmm, this might mean we need to run gtest's configure script to let it define the pre-processor tokens appropriately. I'll look into this.<br>
> FWIW, unittests compile and run fine under gcc 4.1.1, but I don't have gcc 4.1.2 installed locally.<br>
><br>
</div>Do you still have access to our research machines? If so, you should be<br>
able to log into our newer machines (<a href="http://maute.cs.uiuc.edu" target="_blank">maute.cs.uiuc.edu</a> and<br>
<a href="http://gravity.cs.uiuc.edu" target="_blank">gravity.cs.uiuc.edu</a>) and use /usr/bin/g++4.<br>
</blockquote></div></div><div><br>Yes, I do. I just looked into gtest source code, and it doesn't look like it needs any preprocessor tokens to get tr1 to work.<br><br>I tried using /usr/bin/g++4 on this simple one-line file and it failed to compile, saying the header wasn't found:<br>
<br>------8<------<br>#include <tr1/tuple><br>------8<------<br><br>This tells me that the g++ on your system might not be installed correctly, because it works for me with gcc-4.1.1 and also because that is the location of the header in libstdc++:<br>
<br><a href="http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/include/tr1/tuple?view=log" target="_blank">http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/include/tr1/tuple?view=log</a><br><br>so it might be that this RedHat package was badly configured/installed and might need to go on the list of "broken versions of GCC" for LLVM.<br>
</div></div>
</blockquote></div><br>One more note: gcc has been shipping (a subset of) TR1 since gcc-4.0, so any release past that should support compiling that one-line file:<br><ul><li>New containers such as <code>tuple</code>, <code>array</code>,
<code>unordered_set</code>, <code>unordered_map</code>,
<code>unordered_multiset</code>, <code>unordered_multimap</code>.</li></ul>More info here: <a href="http://gcc.gnu.org/gcc-4.0/changes.html">http://gcc.gnu.org/gcc-4.0/changes.html</a> .<br>