<div dir="ltr">Actually, don't, because I just reapplied.<br><br><div class="gmail_quote">On Tue, Sep 2, 2008 at 10:36 AM, Bill Wendling <span dir="ltr"><<a href="mailto:isanbard@gmail.com">isanbard@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Make sure that you regenerate the configure file.<br>
<font color="#888888"><br>
-bw<br>
</font><div><div></div><div class="Wj3C7c"><br>
On Tue, Sep 2, 2008 at 2:51 AM, Matthijs Kooijman <<a href="mailto:matthijs@stdin.nl">matthijs@stdin.nl</a>> wrote:<br>
> Author: matthijs<br>
> Date: Tue Sep  2 04:51:00 2008<br>
> New Revision: 55628<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=55628&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=55628&view=rev</a><br>
> Log:<br>
> Revert r55557, it is causing linking failures on 32bit linux.<br>
><br>
><br>
> Removed:<br>
>    llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4<br>
> Modified:<br>
>    llvm/trunk/<a href="http://Makefile.config.in" target="_blank">Makefile.config.in</a><br>
>    llvm/trunk/Makefile.rules<br>
>    llvm/trunk/autoconf/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
><br>
> Modified: llvm/trunk/<a href="http://Makefile.config.in" target="_blank">Makefile.config.in</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.config.in?rev=55628&r1=55627&r2=55628&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.config.in?rev=55628&r1=55627&r2=55628&view=diff</a><br>

><br>
> ==============================================================================<br>
> --- llvm/trunk/<a href="http://Makefile.config.in" target="_blank">Makefile.config.in</a> (original)<br>
> +++ llvm/trunk/<a href="http://Makefile.config.in" target="_blank">Makefile.config.in</a> Tue Sep  2 04:51:00 2008<br>
> @@ -234,9 +234,6 @@<br>
>  # Do we want to build with position independent code?<br>
>  ENABLE_PIC := @ENABLE_PIC@<br>
><br>
> -# Use -fvisibility-inlines-hidden?<br>
> -ENABLE_VISIBILITY_INLINES_HIDDEN := @ENABLE_VISIBILITY_INLINES_HIDDEN@<br>
> -<br>
>  # This option tells the Makefiles to produce verbose output.<br>
>  # It essentially prints the commands that make is executing<br>
>  #VERBOSE = 1<br>
><br>
> Modified: llvm/trunk/Makefile.rules<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.rules?rev=55628&r1=55627&r2=55628&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/Makefile.rules?rev=55628&r1=55627&r2=55628&view=diff</a><br>

><br>
> ==============================================================================<br>
> --- llvm/trunk/Makefile.rules (original)<br>
> +++ llvm/trunk/Makefile.rules Tue Sep  2 04:51:00 2008<br>
> @@ -241,10 +241,6 @@<br>
>   endif<br>
>  endif<br>
><br>
> -ifeq ($(ENABLE_VISIBILITY_INLINES_HIDDEN),1)<br>
> -    CXX.Flags += -fvisibility-inlines-hidden<br>
> -endif<br>
> -<br>
>  # IF REQUIRES_EH=1 is specified then don't disable exceptions<br>
>  ifndef REQUIRES_EH<br>
>   CXX.Flags += -fno-exceptions<br>
><br>
> Modified: llvm/trunk/autoconf/<a href="http://configure.ac" target="_blank">configure.ac</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=55628&r1=55627&r2=55628&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=55628&r1=55627&r2=55628&view=diff</a><br>

><br>
> ==============================================================================<br>
> --- llvm/trunk/autoconf/<a href="http://configure.ac" target="_blank">configure.ac</a> (original)<br>
> +++ llvm/trunk/autoconf/<a href="http://configure.ac" target="_blank">configure.ac</a> Tue Sep  2 04:51:00 2008<br>
> @@ -975,8 +975,6 @@<br>
>   AC_MSG_ERROR([Prequisites for bindings not satisfied. Fix them or use configure --disable-bindings.])<br>
>  fi<br>
><br>
> -dnl Determine if the compiler supports -fvisibility-inlines-hidden.<br>
> -AC_CXX_USE_VISIBILITY_INLINES_HIDDEN<br>
><br>
>  dnl===-----------------------------------------------------------------------===<br>
>  dnl===<br>
><br>
> Removed: llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4?rev=55627&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4?rev=55627&view=auto</a><br>

><br>
> ==============================================================================<br>
> --- llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4 (original)<br>
> +++ llvm/trunk/autoconf/m4/visibility_inlines_hidden.m4 (removed)<br>
> @@ -1,22 +0,0 @@<br>
> -#<br>
> -# Determine if the compiler accepts -fvisibility-inlines-hidden<br>
> -#<br>
> -# This macro is specific to LLVM.<br>
> -#<br>
> -AC_DEFUN([AC_CXX_USE_VISIBILITY_INLINES_HIDDEN],<br>
> -[AC_CACHE_CHECK([for compiler -fvisibility-inlines-hidden option],<br>
> -                [llvm_cv_cxx_visibility_inlines_hidden],<br>
> -[ AC_LANG_PUSH([C++])<br>
> -  oldcxxflags="$CXXFLAGS"<br>
> -  CXXFLAGS="$CXXFLAGS -fvisibility-inlines-hidden"<br>
> -  AC_COMPILE_IFELSE([AC_LANG_PROGRAM()],<br>
> -    [llvm_cv_cxx_visibility_inlines_hidden=yes],[llvm_cv_cxx_visibility_inlines_hidden=no])<br>
> -  CXXFLAGS="$oldcxxflags"<br>
> -  AC_LANG_POP([C++])<br>
> -])<br>
> -if test "$llvm_cv_cxx_visibility_inlines_hidden" = yes ; then<br>
> -  AC_SUBST([ENABLE_VISIBILITY_INLINES_HIDDEN],[1])<br>
> -else<br>
> -  AC_SUBST([ENABLE_VISIBILITY_INLINES_HIDDEN],[0])<br>
> -fi<br>
> -])<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>