<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 18, 2008, at 4:01 PM, Talin wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">I don't have a problem with changing the method names. The reason I used upper case is because I thought that's what the convention was (the LLVM sources aren't exactly consistent on this point, although there's been considerable improvement since I first wrote this module.)<br> <br>Do you want me to submit another patch, or can you just modify the names?</div></blockquote><div><br></div>Please submit another patch. Thanks!</div><div><br></div><div>Evan</div><div><br><blockquote type="cite"><div dir="ltr"><br><br><div class="gmail_quote">On Mon, Aug 18, 2008 at 1:26 PM, Anton Korobeynikov <span dir="ltr"><<a href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>></span> wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br> > Sorry about the delay in reviewing the patch. I have been away. I<br> > think this looks good. Anton, what do you say?<br> Oh, I'm sorry, I thought I answered to this e-mail.<br> <br> Overall patch looks ok for me. But I'd strongly suggest to change the<br> names again to be consistent with usual LLVM naming:<br> <br> + // Create an anchor with the specified tag.<br> + GlobalVariable * CreateAnchor(unsigned anchorTag, const char *<br> anchorName);<br> +<br> + // Calculate alignement for primitive types.<br> + unsigned GetBasicAlignment(unsigned sizeInBits);<br> +<br> + // Calculate the size of the specified LLVM type.<br> + Constant * getSize(const Type * type);<br> +<br> + // Calculate the alignment of the specified LLVM type.<br> + Constant * getAlignment(const Type * type);<br> CreateAnchor => createAnchor, GetBasicAlignment => getBasicAlignment,<br> etc.<br> <font color="#888888"><br> --<br> With best regards, Anton Korobeynikov.<br> <br> Faculty of Mathematics & Mechanics, Saint Petersburg State University.<br> <br> </font></blockquote></div><br><br clear="all"><br>-- <br>-- Talin<br> </div></blockquote></div><br></body></html>