<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi David,<div><br></div><div>This breaks quite a few tests. See Grawp-PIC nightly tester results. I'll back it out for now.</div><div><br></div><div><span class="Apple-style-span" style="font-family: -webkit-monospace; font-size: 11px; ">New Test Failures:<br>Applications/ClamAV/clamscan [LLC compile, LLC-BETA compile, , LLC] <br>Applications/JM/lencod/lencod [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Applications/kimwitu++/kc [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Applications/oggenc/oggenc [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Applications/SPASS/SPASS [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Applications/sqlite3/sqlite3 [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Applications/treecc/treecc [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/FreeBench/analyzer/analyzer [] <br>Benchmarks/llubenchmark/llu [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MallocBench/cfrac/cfrac [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MallocBench/espresso/espresso [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MiBench/automotive-susan/automotive-susan [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MiBench/consumer-jpeg/consumer-jpeg [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MiBench/consumer-lame/consumer-lame [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MiBench/consumer-typeset/consumer-typeset [LLC compile, LLC-BETA compile, , LLC, LLC-BETA] <br>Benchmarks/MiBench/office-ispell/office-ispell [LLC compile, LLC-BETA compile, , LLC]</span></div><div><font class="Apple-style-span" face="-webkit-monospace" size="3"><span class="Apple-style-span" style="font-size: 11px;">...</span></font></div><div><font class="Apple-style-span" face="-webkit-monospace" size="3"><span class="Apple-style-span" style="font-size: 11px;"><br></span></font></div><div>Evan</div><div><br></div><div><br><div><div>On May 22, 2008, at 2:16 PM, David Greene wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: greened<br>Date: Thu May 22 16:16:33 2008<br>New Revision: 51440<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=51440&view=rev">http://llvm.org/viewvc/llvm-project?rev=51440&view=rev</a><br>Log:<br><br>When rewriting defs and uses after spilling, don't set the weight of a<br>live interval to infinity if the instruction being rewritten is an<br>original remat def instruction. We were only checking against the clone<br>of the remat def which doesn't actually appear in the IR at all.<br><br>Modified:<br> llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp<br><br>Modified: llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp?rev=51440&r1=51439&r2=51440&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp?rev=51440&r1=51439&r2=51440&view=diff</a><br><br>==============================================================================<br>--- llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp (original)<br>+++ llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp Thu May 22 16:16:33 2008<br>@@ -1150,7 +1150,9 @@<br> }<br> MachineBasicBlock *MBB = MI->getParent();<br><br>- if (ImpUse && MI != ReMatDefMI) {<br>+ // ReMatDefMI is a clone and not in the IR at all, so check<br>+ // RefMatOrigDefMI too.<br>+ if (ImpUse && MI != ReMatDefMI && MI != ReMatOrigDefMI) {<br> // Re-matting an instruction with virtual register use. Update the<br> // register interval's spill weight to HUGE_VALF to prevent it from<br> // being spilled.<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></div></blockquote></div><br></div></body></html>