<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; ">Very nice! <DIV><BR class="khtml-block-placeholder"></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>+def NoneFormat : Format<0>; def Pseudo : Format<1>;</DIV><DIV>+def Multiply : Format<2>; def Branch : Format<3>;</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Some naming suggestions. NoneFormat -> Pseudo, Multiply -> MultiplyFrm (or MulFrm).</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>+class AI<dag oops, dag iops, Format f, string opc, string asm, list<dag> pattern></DIV><DIV>+ : I<oops, iops, AddrModeNone, Size4Bytes, IndexModeNone, f, opc, asm,"",pattern>;</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Please watch out for "80 col violations" (tm)! :-)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>+static const unsigned InstBits[] = {</DIV><DIV>+ 0,</DIV><DIV>+ 0,</DIV><DIV>+ 0,</DIV><DIV>+ 0,</DIV><DIV>+ 0,</DIV><DIV>+ 0XE2B00000,</DIV><DIV>+ 0XE0B00000,</DIV><DIV>+ 0XE0B00000,</DIV><DIV>+ 0XE2900000,</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>This is impossible to maintain. Please move opcode bits into .td files. That is, please add it to each instruction definition:</DIV><DIV> // FIXME: Set all opcodes to 0 for now.</DIV><DIV> : InstARM<0, am, sz, im, cstr> {</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Thanks,</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Evan</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV><BR><DIV><DIV>On Jul 30, 2007, at 10:51 AM, Raul Fernandes Herbster wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite">JIT support for ARM is now generating machine code (Thumb and VFP are not supported). Relocation has not been implemented yet. Next patch must provide such feature. Please, send me any feedback.<BR><BR>Thanks in advance, Raul. <BR clear="all"><BR>-- <BR>Raul Fernandes Herbster<BR>Embedded and Pervasive Computing Laboratory - <A href="http://embedded.dee.ufcg.edu.br">embedded.dee.ufcg.edu.br</A><BR>Electrical Engineering Department - DEE - <A href="http://www.dee.ufcg.edu.br"> www.dee.ufcg.edu.br</A><BR>Electrical Engineering and Informatics Center - CEEI<BR>Federal University of Campina Grande - UFCG - <A href="http://www.ufcg.edu.br">www.ufcg.edu.br</A><BR>Caixa Postal 10105<BR>58109-970 Campina Grande - PB - Brasil<SPAN><DIV><patch></DIV></SPAN><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">llvm-commits mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</A></DIV> </BLOCKQUOTE></DIV><BR></DIV></BODY></HTML>