<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV>Hi Raul,</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Good first step! Thanks.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>+bool ARMTargetMachine::addCodeEmitter(FunctionPassManager &PM, bool Fast,</DIV><DIV>+ MachineCodeEmitter &MCE) {</DIV><DIV>+ // FIXME: Move this to TargetJITInfo!</DIV><DIV>+ setRelocationModel(Reloc::Static);</DIV><DIV>+</DIV><DIV>+ setCodeModel(CodeModel::Large);</DIV><DIV>+</DIV><DIV>+ // Machine code emitter pass for ARM.</DIV><DIV>+ PM.add(createARMCodeEmitterPass(*this, MCE));</DIV><DIV>+ return false;</DIV><DIV>+}</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>The setCodeModel() call is unnecessary.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Please don't include header files if they are not necessary. For example, is it necessary to include TargetOptions.h in ARMCodeEmitter.cpp</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Also in ARMCodeEmitter.cpp:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>void Emitter::emitInstruction(const MachineInstr &MI) {</DIV><DIV> NumEmitted++; // Keep track of the # of mi's emitted </DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>}</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Please remove the blank line. :-)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>ARMJITInfo.h:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>// This file contains the ARM implementation of the TargetJITInfo class. </DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Not accurate. Something like "This file contains the declaration of the ARMJITInfo class." (I'll fix the similar problems in other targets. :-)</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Can you fix the problems and resubmit the patch? BTW, I can't patch cleanly:</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Patching file lib/Target/ARM/ARMTargetMachine.cpp using Plan A...</DIV><DIV>Hunk #1 succeeded at 33.</DIV><DIV>patch: **** malformed patch at line 90: @@ -106,3 +129,22 @@</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Please fix that as well.</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Thanks,</DIV><DIV><BR class="khtml-block-placeholder"></DIV><DIV>Evan</DIV><DIV><BR class="khtml-block-placeholder"></DIV><BR><DIV><DIV>On Jun 27, 2007, at 11:26 AM, Raul Fernandes Herbster wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite">This is an initial implementation of ARM JIT support. So far, it hasn't generated code machine yet. Next patch must provide such feature. The tar.gz file must be unpacked under lib/Target/ARM directory. Please, send me any feedback. <BR><BR>Best regards, Raul.<BR clear="all"><BR>-- <BR>Raul Fernandes Herbster<BR>Embedded and Pervasive Computing Laboratory - <A href="http://embedded.dee.ufcg.edu.br">embedded.dee.ufcg.edu.br</A><BR>Electrical Engineering Department - DEE - <A href="http://www.dee.ufcg.edu.br">www.dee.ufcg.edu.br</A><BR>Electrical Engineering and Informatics Center - CEEI<BR>Federal University of Campina Grande - UFCG - <A href="http://www.ufcg.edu.br">www.ufcg.edu.br</A><BR> Caixa Postal 10105<BR>58109-970 Campina Grande - PB - Brasil<SPAN><DIV><arm_jit_patch></DIV></SPAN><SPAN><DIV><arm_jit.tar.gz></DIV></SPAN><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">_______________________________________________</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">llvm-commits mailing list</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</A></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><A href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</A></DIV> </BLOCKQUOTE></DIV><BR></BODY></HTML>