<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Reid Spencer wrote:
<blockquote cite="mid1177174428.20748.77.camel@bashful.x10sys.com"
type="cite">
<pre wrap="">Jeff,
On Sat, 2007-04-21 at 11:29 -0500, Jeff Cohen wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Changes in directory llvm/include/llvm/CodeGen:
MachineRelocation.h updated: 1.12 -> 1.13
---
Log message:
Make enum-valued bitfield large enough to avoid interpretation as negative values in VC++.
---
Diffs of the changes: (+1 -1)
MachineRelocation.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: llvm/include/llvm/CodeGen/MachineRelocation.h
diff -u llvm/include/llvm/CodeGen/MachineRelocation.h:1.12 llvm/include/llvm/CodeGen/MachineRelocation.h:1.13
--- llvm/include/llvm/CodeGen/MachineRelocation.h:1.12 Sun Dec 10 20:19:29 2006
+++ llvm/include/llvm/CodeGen/MachineRelocation.h Sat Apr 21 11:29:37 2007
@@ -63,7 +63,7 @@
} Target;
unsigned TargetReloType : 6; // The target relocation ID.
- AddressType AddrType : 3; // The field of Target to use.
+ AddressType AddrType : 4; // The field of Target to use.
</pre>
</blockquote>
<pre wrap=""><!---->
Can't we just make AddressType "unsigned" ? Surely VC++ won't treat
something explicitly declared as unsigned as a signed quantity. Then we
shouldn't need the extra bit, right?
Reid.</pre>
</blockquote>
<br>
Not without inserting a whole bunch of casts elsewhere. Unsigneds
cannot be assigned to enums.<br>
</body>
</html>