[llvm] [AMDGPU] Fix predicates for BUFFER_ATOMIC_FMIN/FMAX patterns (PR #89066)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 05:52:59 PDT 2024


================
@@ -1726,7 +1726,7 @@ let SubtargetPredicate = isGFX12Plus in {
   defm : SIBufferAtomicPat_Common<"SIbuffer_atomic_cond_sub_u32", i32, "BUFFER_ATOMIC_COND_SUB_U32_VBUFFER", ["noret"]>;
 }
 
-let SubtargetPredicate = isGFX6GFX7GFX10Plus in {
+let OtherPredicates = [isGFX6GFX7GFX10Plus] in {
----------------
jayfoad wrote:

It is annoying not to be able to use `SubtargetPredicate` for something that is clearly a subtarget predicate, but it clashes with the use of `SubtargetPredicate = HasUnrestrictedSOffset` inside `SIBufferAtomicPat`.

https://github.com/llvm/llvm-project/pull/89066


More information about the llvm-commits mailing list