[llvm] RenameIndependentSubregs: Add missing sub-range for new IMPLICIT_DEFs (PR #89050)

Petar Avramovic via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 05:06:22 PDT 2024


petar-avramovic wrote:

> What was the effect of the bug? Was it failing MachineVerifier, or just generating incorrect code? Do you have a small test case? Or do the tests updated in this PR show the fix - and if so, can you point out where?

Incorrect code for GlobalISel. It was deleting copies from sgpr to vgpr, sdag was moving everything to VALU so it was not affected by this bug. Instruction deletion shows on some very large tests, change is visible in live intervals if you dump them. Will look into writing mir test.

https://github.com/llvm/llvm-project/pull/89050


More information about the llvm-commits mailing list