[llvm] [LLVM][AARCH64]Replace +sme2p1+smef16f16 by +smef16f16 (PR #88860)

Momchil Velikov via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 03:48:45 PDT 2024


================
@@ -554,7 +554,7 @@ def FeatureSME_LUTv2 : SubtargetFeature<"sme-lutv2", "HasSME_LUTv2", "true",
   "Enable Scalable Matrix Extension (SME) LUTv2 instructions (FEAT_SME_LUTv2)">;
 
 def FeatureSMEF8F16 : SubtargetFeature<"sme-f8f16", "HasSMEF8F16", "true",
-  "Enable Scalable Matrix Extension (SME) F8F16 instructions(FEAT_SME_F8F16)", [FeatureSME2, FeatureFP8]>;
+  "Enable Scalable Matrix Extension (SME) F8F16 instructions(FEAT_SME_F8F16)", [FeatureSME2, FeatureFP8, FeatureSMEF16F16]>;
----------------
momchil-velikov wrote:

Likewise, `FeatureSMEF16F16` ought to imply `FeatureSME2` and `FeatureSME` can be removed here.

The idea is to not specify explicitly dependencies that can be transitively derived - 
if you have `A -> B -> C -> D` better to write `A -> B`, `B -> C`, and `C -> D` instead of
`A -> B, C, D`, `B -> C, D`, `C -> D`.


https://github.com/llvm/llvm-project/pull/88860


More information about the llvm-commits mailing list