[llvm] 6a85cf8 - [SelectionDAG] Verify SPLAT_VECTOR nodes when they are created. (#88305)

via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 10:22:25 PDT 2024


Author: Craig Topper
Date: 2024-04-12T10:22:21-07:00
New Revision: 6a85cf8fc0437d4885fc829948befe32c1e5a21d

URL: https://github.com/llvm/llvm-project/commit/6a85cf8fc0437d4885fc829948befe32c1e5a21d
DIFF: https://github.com/llvm/llvm-project/commit/6a85cf8fc0437d4885fc829948befe32c1e5a21d.diff

LOG: [SelectionDAG] Verify SPLAT_VECTOR nodes when they are created. (#88305)

This applies the same rules we have for the scalar operands of a
BUILD_VECTOR where the scalar type must match the element type or for
integer vectors we allow the scalar type to be larger than the element
type. Hexagon uses i32 for an FP zero vector so we allow that as an
exception.

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index ddb12a101e02cd..412e1de9fc41ca 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6032,6 +6032,17 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
     if (N1.getValueType().getScalarType() == MVT::i1)
       return getNode(ISD::VECREDUCE_AND, DL, VT, N1);
     break;
+  case ISD::SPLAT_VECTOR:
+    assert(VT.isVector() && "Wrong return type!");
+    // FIXME: Hexagon uses i32 scalar for a floating point zero vector so allow
+    // that for now.
+    assert((VT.getVectorElementType() == N1.getValueType() ||
+            (VT.isFloatingPoint() && N1.getValueType() == MVT::i32) ||
+            (VT.getVectorElementType().isInteger() &&
+             N1.getValueType().isInteger() &&
+             VT.getVectorElementType().bitsLE(N1.getValueType()))) &&
+           "Wrong operand type!");
+    break;
   }
 
   SDNode *N;


        


More information about the llvm-commits mailing list