[llvm] [Support] Fix the issue where the character being saved in Unicode causes a warning to be treated as an error in Visual Studio 2022. (PR #88513)

via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 07:02:41 PDT 2024


https://github.com/TSWorld1314 updated https://github.com/llvm/llvm-project/pull/88513

>From 649703d1b0db89718ef71d9f39d0efaca11f3dc0 Mon Sep 17 00:00:00 2001
From: "Harrison,Hao" <tsworld1314 at gmail.com>
Date: Fri, 12 Apr 2024 13:40:15 +0000
Subject: [PATCH 1/2] [Support] Fix the issue where the character being saved
 in Unicode causes a warning to be treated as an error in Visual Studio 2022.

---
 llvm/lib/Support/Parallel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Support/Parallel.cpp b/llvm/lib/Support/Parallel.cpp
index 9b14b05b521160..fe7834c86e3d0e 100644
--- a/llvm/lib/Support/Parallel.cpp
+++ b/llvm/lib/Support/Parallel.cpp
@@ -57,7 +57,7 @@ class ThreadPoolExecutor : public Executor {
     Threads.resize(1);
     std::lock_guard<std::mutex> Lock(Mutex);
     // Use operator[] before creating the thread to avoid data race in .size()
-    // in “safe libc++” mode.
+    // in "safe libc++" mode.
     auto &Thread0 = Threads[0];
     Thread0 = std::thread([this, S] {
       for (unsigned I = 1; I < ThreadCount; ++I) {

>From 2f8f0ce43fe50464975072da4955902a6803b694 Mon Sep 17 00:00:00 2001
From: "Harrison,Hao" <tsworld1314 at gmail.com>
Date: Fri, 12 Apr 2024 14:02:23 +0000
Subject: [PATCH 2/2] [Support] Chang to single quotes.

---
 llvm/lib/Support/Parallel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Support/Parallel.cpp b/llvm/lib/Support/Parallel.cpp
index fe7834c86e3d0e..af35947192c0db 100644
--- a/llvm/lib/Support/Parallel.cpp
+++ b/llvm/lib/Support/Parallel.cpp
@@ -57,7 +57,7 @@ class ThreadPoolExecutor : public Executor {
     Threads.resize(1);
     std::lock_guard<std::mutex> Lock(Mutex);
     // Use operator[] before creating the thread to avoid data race in .size()
-    // in "safe libc++" mode.
+    // in 'safe libc++' mode.
     auto &Thread0 = Threads[0];
     Thread0 = std::thread([this, S] {
       for (unsigned I = 1; I < ThreadCount; ++I) {



More information about the llvm-commits mailing list