[llvm] [LoopUnroll] Ignore inlinable calls if unrolling is forced (#88141) (PR #88149)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 07:59:06 PDT 2024


fhahn wrote:

> This is a useful metric, but causes linker warnings if:

>From the description, it's not clear what kind of warnings this would yield. Looking at the linked issue, it's remarks that get printed by default (`loop not unrolled: the optimizer was unable to perform the requested transformation; the transformation might be disabled or specified as part of an unsupported transformation ordering`). 

Would be good to clarify in the description.

Regardless of the patch at hand, I don't think we really should print those messages by default; there are other reasons why the compiler won't unroll a loop even if forced by the user.

Could you also add a link to https://github.com/llvm/llvm-project/issues/88141 in the description, not in the title as ` (#88141) `? This could be confusing as Github will add the PR ID in a similar fashion when landing.

https://github.com/llvm/llvm-project/pull/88149


More information about the llvm-commits mailing list