[llvm] [ValueTracking] Improve knownbits from conditions where `Val` is used by `and`/`or`. (PR #86059)

via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 09:23:12 PDT 2024


goldsteinn wrote:

> The implementation looks ok to me. I'll leave it to @dtcxzyw to decide if we really need this. Diffs don't look particularly compelling to me.

Yeah I guess an empty diff isn't really all that exciting. For my money, if there is no-compile time impact, its better to have it covered than not, especially since I think there will end up being minimal code complexity added since the `add nuw`/`sub nuw` cases have a positive diff so if those get in, the impl of the two cases will overlap. But LMK either way.

https://github.com/llvm/llvm-project/pull/86059


More information about the llvm-commits mailing list