[llvm] [z/OS][GOFF] Implement support for writing ESD + TXT records by the GOFFObjectWriter (PR #85851)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 04:20:39 PDT 2024


================
@@ -1014,6 +1016,8 @@ void SystemZAsmPrinter::emitADASection() {
                                 MCSymbolRefExpr::create(Sym, OutContext),
                                 OutContext),
           PointerSize);
+      Sym->setExecutable(GOFF::ESD_EXE_CODE);
----------------
uweigand wrote:

Thinking about this a bit more, I actually like the current approach of setting this flag in doFinalization once for every external symbol.  (I think you should probably exclude internal symbols there, however.)

Given that this behavior is actually quite a bit different from the ELF .type handling (which applies only to defined symbols), however, I now think it would indeed be better to define some new MCSA_GOFF_ attributes rather than reusing the ELF_Type attributes.  We'll need other GOFF-specific symbol attributes anyway.


https://github.com/llvm/llvm-project/pull/85851


More information about the llvm-commits mailing list