[llvm] [WebAssembly] Allocate MCSymbolWasm data on MCContext. (PR #85866)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 22:46:04 PDT 2024


MaskRay wrote:

> I've called the added method allocateGenericString and added the second paragraph of its documentation to maybe guide people a bit on when to use this method (based on my (limited) understanding of the MCContext class). We could also just call it allocateString and remove that second paragraph.

The shorter `allocateString` looks good to me.

> @MaskRay: Since you are part of pr-subscribers-mc, would you be an appropriate reviewer of the MCContext portion of this PR (or can you recommend someone else)?

LGTM.


https://github.com/llvm/llvm-project/pull/85866


More information about the llvm-commits mailing list