[lld] 09403a6 - [ELF,test] Improve "non-exported symbol" tests

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 23:26:35 PDT 2024


Author: Fangrui Song
Date: 2024-03-29T23:26:29-07:00
New Revision: 09403a66c01ef189c5e6993410fc9e082acaccf2

URL: https://github.com/llvm/llvm-project/commit/09403a66c01ef189c5e6993410fc9e082acaccf2
DIFF: https://github.com/llvm/llvm-project/commit/09403a66c01ef189c5e6993410fc9e082acaccf2.diff

LOG: [ELF,test] Improve "non-exported symbol" tests

Test that the error is not triggered when we see the non-exported
definition first (#86777).

Added: 
    

Modified: 
    lld/test/ELF/allow-shlib-undefined.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/allow-shlib-undefined.s b/lld/test/ELF/allow-shlib-undefined.s
index 4b7151c8bc0d56..053cb80e2b9d1c 100644
--- a/lld/test/ELF/allow-shlib-undefined.s
+++ b/lld/test/ELF/allow-shlib-undefined.s
@@ -31,10 +31,14 @@
 
 ## Test some cases when a relocatable object file provides a non-exported definition.
 # RUN: not ld.lld main.o a.so def-hidden.o -o /dev/null 2>&1 | FileCheck %s --check-prefix=NONEXPORTED
+## TODO
+# RUN: ld.lld main.o def-hidden.o a.so -o /dev/null
 # RUN: not ld.lld main.o a.so def-hidden.o -shared --no-allow-shlib-undefined -o /dev/null 2>&1 | FileCheck %s --check-prefix=NONEXPORTED
 # RUN: ld.lld main.o a.so def-hidden.o --allow-shlib-undefined --fatal-warnings -o /dev/null
 ## Test a relocatable object file definition that is converted to STB_LOCAL.
 # RUN: not ld.lld main.o a.so def-hidden.o --version-script=local.ver -o /dev/null 2>&1 | FileCheck %s --check-prefix=NONEXPORTED
+## TODO
+# RUN: ld.lld main.o def-hidden.o a.so --version-script=local.ver -o /dev/null
 
 ## The section containing the definition is discarded, and we report an error.
 # RUN: not ld.lld --gc-sections main.o a.so def-hidden.o -o /dev/null 2>&1 | FileCheck %s


        


More information about the llvm-commits mailing list