[clang] [llvm] [Offload] Change unregister library to use `atexit` instead of destructor (PR #86830)

Yaxun Liu via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 10:47:57 PDT 2024


================
@@ -186,57 +186,60 @@ GlobalVariable *createBinDesc(Module &M, ArrayRef<ArrayRef<char>> Bufs,
                             ".omp_offloading.descriptor" + Suffix);
 }
 
-void createRegisterFunction(Module &M, GlobalVariable *BinDesc,
-                            StringRef Suffix) {
+Function *createUnregisterFunction(Module &M, GlobalVariable *BinDesc,
----------------
yxsamliu wrote:

It seems the order of createRegisterFunction and createUnregisterFunction is swapped. This causes some artificial differences. Is it OK to keep their original order.

https://github.com/llvm/llvm-project/pull/86830


More information about the llvm-commits mailing list