[compiler-rt] [compiler-rt] Don't check COMPILER_RT_STANDALONE_BUILD for test deps (PR #83651)

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 13:18:40 PDT 2024


arichardson wrote:

> Echo-ing the [comment](https://github.com/llvm/llvm-project/pull/66259#issuecomment-1726623392) made by @smeenai, checking for `COMPILER_RT_HAS_MSAN` or `COMPILER_RT_HAS_DFSAN` only checks whether the machine can support it, but not whether the user decides to build it (which ends up becoming a missing dep since we don't build for these sanitizers). Our workaround is to build it, but we don't need it, and it increases our build time. Have we thought about any other workarounds?

Does this refer to the changes in libfuzzer?

I guess the cleanest option here would be to have COMPILER_RT_HAS_MSAN be false when COMPILER_RT_TEST_STANDALONE_BUILD_LIBS (https://github.com/llvm/llvm-project/pull/83088) is set but msan runtimes are not being built.



https://github.com/llvm/llvm-project/pull/83651


More information about the llvm-commits mailing list