[llvm] [llvm-debuginfo-analyzer] Rename LVElfReader.cpp[h] (PR #85530)
Carlos Alberto Enciso via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 16 08:01:28 PDT 2024
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/85530
>From 4389e9d2b8d142f5c58e17bea09dbc80b7b3b008 Mon Sep 17 00:00:00 2001
From: Carlos Alberto Enciso <carlos.alberto.enciso at gmail.com>
Date: Sat, 16 Mar 2024 14:23:13 +0000
Subject: [PATCH 1/2] [llvm-debuginfo-analyzer] Rename LVElfReader.cpp[h]
As part of the WebAssembly support work review
https://github.com/llvm/llvm-project/pull/82588
It was decided to rename:
Files: LVElfReader.cpp[h] -> LVDWARFReader.cpp[h]
ELFReaderTest.cpp -> DWARFReaderTest.cpp
Class: LVELFReader -> LVDWARFReader
The name LVDWARFReader would match the another reader
LVCodeViewReader as they will reflect the type of
debug information format that they are parsing.
---
.../{LVELFReader.h => LVDWARFReader.h} | 22 +++---
llvm/lib/DebugInfo/LogicalView/CMakeLists.txt | 2 +-
.../DebugInfo/LogicalView/LVReaderHandler.cpp | 5 +-
.../{LVELFReader.cpp => LVDWARFReader.cpp} | 67 ++++++++++---------
.../DWARF/dw-at-specification.test | 2 +-
...-57040-ignored-DW_FORM_implicit_const.test | 2 +-
llvm/tools/llvm-debuginfo-analyzer/README.txt | 4 +-
.../DebugInfo/LogicalView/CMakeLists.txt | 2 +-
...{ELFReaderTest.cpp => DWARFReaderTest.cpp} | 4 +-
.../llvm/lib/DebugInfo/LogicalView/BUILD.gn | 2 +-
.../unittests/DebugInfo/LogicalView/BUILD.gn | 2 +-
11 files changed, 58 insertions(+), 56 deletions(-)
rename llvm/include/llvm/DebugInfo/LogicalView/Readers/{LVELFReader.h => LVDWARFReader.h} (89%)
rename llvm/lib/DebugInfo/LogicalView/Readers/{LVELFReader.cpp => LVDWARFReader.cpp} (95%)
rename llvm/unittests/DebugInfo/LogicalView/{ELFReaderTest.cpp => DWARFReaderTest.cpp} (99%)
diff --git a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
similarity index 89%
rename from llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h
rename to llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
index 0837b886a273a6..2417ad0d5cef06 100644
--- a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVELFReader.h
+++ b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
@@ -1,4 +1,4 @@
-//===-- LVELFReader.h -------------------------------------------*- C++ -*-===//
+//===-- LVDWARFReader.h -----------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -6,13 +6,13 @@
//
//===----------------------------------------------------------------------===//
//
-// This file defines the LVELFReader class, which is used to describe a
+// This file defines the LVDWARFReader class, which is used to describe a
// debug information (DWARF) reader.
//
//===----------------------------------------------------------------------===//
-#ifndef LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVELFREADER_H
-#define LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVELFREADER_H
+#ifndef LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVDWARFREADER_H
+#define LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVDWARFREADER_H
#include "llvm/DebugInfo/DWARF/DWARFAbbreviationDeclaration.h"
#include "llvm/DebugInfo/DWARF/DWARFContext.h"
@@ -30,7 +30,7 @@ class LVType;
using AttributeSpec = DWARFAbbreviationDeclaration::AttributeSpec;
-class LVELFReader final : public LVBinaryReader {
+class LVDWARFReader final : public LVBinaryReader {
object::ObjectFile &Obj;
// Indicates if ranges data are available; in the case of split DWARF any
@@ -127,14 +127,14 @@ class LVELFReader final : public LVBinaryReader {
void sortScopes() override;
public:
- LVELFReader() = delete;
- LVELFReader(StringRef Filename, StringRef FileFormatName,
+ LVDWARFReader() = delete;
+ LVDWARFReader(StringRef Filename, StringRef FileFormatName,
object::ObjectFile &Obj, ScopedPrinter &W)
: LVBinaryReader(Filename, FileFormatName, W, LVBinaryType::ELF),
Obj(Obj) {}
- LVELFReader(const LVELFReader &) = delete;
- LVELFReader &operator=(const LVELFReader &) = delete;
- ~LVELFReader() = default;
+ LVDWARFReader(const LVDWARFReader &) = delete;
+ LVDWARFReader &operator=(const LVDWARFReader &) = delete;
+ ~LVDWARFReader() = default;
LVAddress getCUBaseAddress() const { return CUBaseAddress; }
void setCUBaseAddress(LVAddress Address) { CUBaseAddress = Address; }
@@ -158,4 +158,4 @@ class LVELFReader final : public LVBinaryReader {
} // end namespace logicalview
} // end namespace llvm
-#endif // LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVELFREADER_H
+#endif // LLVM_DEBUGINFO_LOGICALVIEW_READERS_LVDWARFREADER_H
diff --git a/llvm/lib/DebugInfo/LogicalView/CMakeLists.txt b/llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
index 38a174661b4f3f..f5adab723927a9 100644
--- a/llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
+++ b/llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
@@ -24,7 +24,7 @@ add_lv_impl_folder(Readers
Readers/LVBinaryReader.cpp
Readers/LVCodeViewReader.cpp
Readers/LVCodeViewVisitor.cpp
- Readers/LVELFReader.cpp
+ Readers/LVDWARFReader.cpp
)
list(APPEND LIBLV_ADDITIONAL_HEADER_DIRS
diff --git a/llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp b/llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp
index 16c4fbed1423fb..c8410154059535 100644
--- a/llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp
@@ -14,7 +14,7 @@
#include "llvm/DebugInfo/CodeView/LazyRandomTypeCollection.h"
#include "llvm/DebugInfo/LogicalView/Core/LVCompare.h"
#include "llvm/DebugInfo/LogicalView/Readers/LVCodeViewReader.h"
-#include "llvm/DebugInfo/LogicalView/Readers/LVELFReader.h"
+#include "llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h"
#include "llvm/DebugInfo/PDB/Native/NativeSession.h"
#include "llvm/DebugInfo/PDB/PDB.h"
#include "llvm/Object/COFF.h"
@@ -49,7 +49,8 @@ Error LVReaderHandler::createReader(StringRef Filename, LVReaders &Readers,
*COFF, W, ExePath);
}
if (Obj.isELF() || Obj.isMachO() || Obj.isWasm())
- return std::make_unique<LVELFReader>(Filename, FileFormatName, Obj, W);
+ return std::make_unique<LVDWARFReader>(Filename, FileFormatName, Obj,
+ W);
}
if (isa<PDBFile *>(Input)) {
PDBFile &Pdb = *cast<PDBFile *>(Input);
diff --git a/llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
similarity index 95%
rename from llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp
rename to llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
index 6bdcbc0ab641b0..91e5a037054da0 100644
--- a/llvm/lib/DebugInfo/LogicalView/Readers/LVELFReader.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
@@ -1,4 +1,4 @@
-//===-- LVELFReader.cpp ---------------------------------------------------===//
+//===-- LVDWARFReader.cpp -------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -6,12 +6,12 @@
//
//===----------------------------------------------------------------------===//
//
-// This implements the LVELFReader class.
+// This implements the LVDWARFReader class.
// It supports ELF, Mach-O and Wasm binary formats.
//
//===----------------------------------------------------------------------===//
-#include "llvm/DebugInfo/LogicalView/Readers/LVELFReader.h"
+#include "llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h"
#include "llvm/DebugInfo/DIContext.h"
#include "llvm/DebugInfo/DWARF/DWARFDebugLoc.h"
#include "llvm/DebugInfo/DWARF/DWARFExpression.h"
@@ -27,9 +27,9 @@ using namespace llvm;
using namespace llvm::object;
using namespace llvm::logicalview;
-#define DEBUG_TYPE "ElfReader"
+#define DEBUG_TYPE "DWARFReader"
-LVElement *LVELFReader::createElement(dwarf::Tag Tag) {
+LVElement *LVDWARFReader::createElement(dwarf::Tag Tag) {
CurrentScope = nullptr;
CurrentSymbol = nullptr;
CurrentType = nullptr;
@@ -243,8 +243,9 @@ LVElement *LVELFReader::createElement(dwarf::Tag Tag) {
return nullptr;
}
-void LVELFReader::processOneAttribute(const DWARFDie &Die, LVOffset *OffsetPtr,
- const AttributeSpec &AttrSpec) {
+void LVDWARFReader::processOneAttribute(const DWARFDie &Die,
+ LVOffset *OffsetPtr,
+ const AttributeSpec &AttrSpec) {
uint64_t OffsetOnEntry = *OffsetPtr;
DWARFUnit *U = Die.getDwarfUnit();
const DWARFFormValue &FormValue =
@@ -515,8 +516,8 @@ void LVELFReader::processOneAttribute(const DWARFDie &Die, LVOffset *OffsetPtr,
}
}
-LVScope *LVELFReader::processOneDie(const DWARFDie &InputDIE, LVScope *Parent,
- DWARFDie &SkeletonDie) {
+LVScope *LVDWARFReader::processOneDie(const DWARFDie &InputDIE, LVScope *Parent,
+ DWARFDie &SkeletonDie) {
// If the input DIE corresponds to the compile unit, it can be:
// a) Simple DWARF: a standard DIE. Ignore the skeleton DIE (is empty).
// b) Split DWARF: the DIE for the split DWARF. The skeleton is the DIE
@@ -688,8 +689,8 @@ LVScope *LVELFReader::processOneDie(const DWARFDie &InputDIE, LVScope *Parent,
return CurrentScope;
}
-void LVELFReader::traverseDieAndChildren(DWARFDie &DIE, LVScope *Parent,
- DWARFDie &SkeletonDie) {
+void LVDWARFReader::traverseDieAndChildren(DWARFDie &DIE, LVScope *Parent,
+ DWARFDie &SkeletonDie) {
// Process the current DIE.
LVScope *Scope = processOneDie(DIE, Parent, SkeletonDie);
if (Scope) {
@@ -709,13 +710,13 @@ void LVELFReader::traverseDieAndChildren(DWARFDie &DIE, LVScope *Parent,
}
}
-void LVELFReader::processLocationGaps() {
+void LVDWARFReader::processLocationGaps() {
if (options().getAttributeAnyLocation())
for (LVSymbol *Symbol : SymbolsWithLocations)
Symbol->fillLocationGaps();
}
-void LVELFReader::createLineAndFileRecords(
+void LVDWARFReader::createLineAndFileRecords(
const DWARFDebugLine::LineTable *Lines) {
if (!Lines)
return;
@@ -772,8 +773,8 @@ void LVELFReader::createLineAndFileRecords(
}
}
-std::string LVELFReader::getRegisterName(LVSmall Opcode,
- ArrayRef<uint64_t> Operands) {
+std::string LVDWARFReader::getRegisterName(LVSmall Opcode,
+ ArrayRef<uint64_t> Operands) {
// The 'prettyPrintRegisterOp' function uses the DWARFUnit to support
// DW_OP_regval_type. At this point we are operating on a logical view
// item, with no access to the underlying DWARF data used by LLVM.
@@ -800,7 +801,7 @@ std::string LVELFReader::getRegisterName(LVSmall Opcode,
return Stream.str();
}
-Error LVELFReader::createScopes() {
+Error LVDWARFReader::createScopes() {
LLVM_DEBUG({
W.startLine() << "\n";
W.printString("File", Obj.getFileName().str());
@@ -980,11 +981,11 @@ Error LVELFReader::createScopes() {
}
// Get the location information for the associated attribute.
-void LVELFReader::processLocationList(dwarf::Attribute Attr,
- const DWARFFormValue &FormValue,
- const DWARFDie &Die,
- uint64_t OffsetOnEntry,
- bool CallSiteLocation) {
+void LVDWARFReader::processLocationList(dwarf::Attribute Attr,
+ const DWARFFormValue &FormValue,
+ const DWARFDie &Die,
+ uint64_t OffsetOnEntry,
+ bool CallSiteLocation) {
auto ProcessLocationExpression = [&](const DWARFExpression &Expression) {
for (const DWARFExpression::Operation &Op : Expression)
@@ -1061,10 +1062,10 @@ void LVELFReader::processLocationList(dwarf::Attribute Attr,
}
}
-void LVELFReader::processLocationMember(dwarf::Attribute Attr,
- const DWARFFormValue &FormValue,
- const DWARFDie &Die,
- uint64_t OffsetOnEntry) {
+void LVDWARFReader::processLocationMember(dwarf::Attribute Attr,
+ const DWARFFormValue &FormValue,
+ const DWARFDie &Die,
+ uint64_t OffsetOnEntry) {
// Check if the value is an integer constant.
if (FormValue.isFormClass(DWARFFormValue::FC_Constant))
// Add a record to hold a constant as location.
@@ -1076,8 +1077,8 @@ void LVELFReader::processLocationMember(dwarf::Attribute Attr,
}
// Update the current element with the reference.
-void LVELFReader::updateReference(dwarf::Attribute Attr,
- const DWARFFormValue &FormValue) {
+void LVDWARFReader::updateReference(dwarf::Attribute Attr,
+ const DWARFFormValue &FormValue) {
// FIXME: We are assuming that at most one Reference (DW_AT_specification,
// DW_AT_abstract_origin, ...) and at most one Type (DW_AT_import, DW_AT_type)
// appear in any single DIE, but this may not be true.
@@ -1129,8 +1130,8 @@ void LVELFReader::updateReference(dwarf::Attribute Attr,
}
// Get an element given the DIE offset.
-LVElement *LVELFReader::getElementForOffset(LVOffset Offset, LVElement *Element,
- bool IsType) {
+LVElement *LVDWARFReader::getElementForOffset(LVOffset Offset,
+ LVElement *Element, bool IsType) {
auto Iter = ElementTable.try_emplace(Offset).first;
// Update the element and all the references pointing to this element.
LVElementEntry &Entry = Iter->second;
@@ -1143,7 +1144,7 @@ LVElement *LVELFReader::getElementForOffset(LVOffset Offset, LVElement *Element,
return Entry.Element;
}
-Error LVELFReader::loadTargetInfo(const ObjectFile &Obj) {
+Error LVDWARFReader::loadTargetInfo(const ObjectFile &Obj) {
// Detect the architecture from the object file. We usually don't need OS
// info to lookup a target and create register info.
Triple TT;
@@ -1162,7 +1163,7 @@ Error LVELFReader::loadTargetInfo(const ObjectFile &Obj) {
return loadGenericTargetInfo(TT.str(), FeaturesValue.getString());
}
-void LVELFReader::mapRangeAddress(const ObjectFile &Obj) {
+void LVDWARFReader::mapRangeAddress(const ObjectFile &Obj) {
for (auto Iter = Obj.symbol_begin(); Iter != Obj.symbol_end(); ++Iter) {
const SymbolRef &Symbol = *Iter;
@@ -1238,9 +1239,9 @@ void LVELFReader::mapRangeAddress(const ObjectFile &Obj) {
}
}
-void LVELFReader::sortScopes() { Root->sort(); }
+void LVDWARFReader::sortScopes() { Root->sort(); }
-void LVELFReader::print(raw_ostream &OS) const {
+void LVDWARFReader::print(raw_ostream &OS) const {
OS << "LVType\n";
LLVM_DEBUG(dbgs() << "CreateReaders\n");
}
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test
index 9c9118ea49f8ab..b1b35e4f4fe3ed 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/dw-at-specification.test
@@ -10,7 +10,7 @@
; The above test compiled with clang++ produces both a DW_AT_type and
; DW_AT_specification on the definition die for S::Arr, which previously caused
-; an assert in the LVELFReader:
+; an assert in the LVDWARFReader:
; $ clang++ -g -c dw-at-specification.cpp -o dw-at-specification.o
; RUN: llvm-debuginfo-analyzer --attribute=level,format,producer \
diff --git a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test
index 7ee9f3118d0aa9..9df058c5598052 100644
--- a/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test
+++ b/llvm/test/tools/llvm-debuginfo-analyzer/DWARF/pr-57040-ignored-DW_FORM_implicit_const.test
@@ -14,7 +14,7 @@
; DW_AT_decl_file DW_FORM_implicit_const 1
; DW_AT_decl_line DW_FORM_data1
-; Attributes with DW_FORM_implicit_const being ignored by the ELFReader,
+; Attributes with DW_FORM_implicit_const being ignored by the DWARFReader,
; causing {Parameter} and {TypeAlias} to omit line numbers.
; test.cpp
diff --git a/llvm/tools/llvm-debuginfo-analyzer/README.txt b/llvm/tools/llvm-debuginfo-analyzer/README.txt
index e6c20db7cd7121..a38f918d144472 100644
--- a/llvm/tools/llvm-debuginfo-analyzer/README.txt
+++ b/llvm/tools/llvm-debuginfo-analyzer/README.txt
@@ -31,11 +31,11 @@ use LIT tests to validate the logical readers.
Convert the unitests:
llvm-project/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
- llvm-project/llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp
+ llvm-project/llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
into LIT tests:
llvm-project/llvm/test/DebugInfo/LogicalView/CodeViewReader.test
- llvm-project/llvm/test/DebugInfo/LogicalView/ELFReader.test
+ llvm-project/llvm/test/DebugInfo/LogicalView/DWARFReader.test
//===----------------------------------------------------------------------===//
// Eliminate calls to 'getInputFileDirectory()' in the unit tests.
diff --git a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
index 1b93d77a20bd69..1116edb212b057 100644
--- a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
+++ b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
@@ -12,7 +12,7 @@ add_llvm_unittest_with_input_files(DebugInfoLogicalViewTests
CodeViewReaderTest.cpp
CommandLineOptionsTest.cpp
CompareElementsTest.cpp
- ELFReaderTest.cpp
+ DWARFReaderTest.cpp
SelectElementsTest.cpp
LocationRangesTest.cpp
LogicalElementsTest.cpp
diff --git a/llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp b/llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
similarity index 99%
rename from llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp
rename to llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
index bd278befbc642f..a1bd5dee356566 100644
--- a/llvm/unittests/DebugInfo/LogicalView/ELFReaderTest.cpp
+++ b/llvm/unittests/DebugInfo/LogicalView/DWARFReaderTest.cpp
@@ -1,4 +1,4 @@
-//===- llvm/unittest/DebugInfo/LogicalView/ELFReaderTest.cpp --------------===//
+//===- llvm/unittest/DebugInfo/LogicalView/DWARFReaderTest.cpp ------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
@@ -323,7 +323,7 @@ void compareElements(SmallString<128> &InputsDir) {
checkElementComparison(Reference.get(), Target.get());
}
-TEST(LogicalViewTest, ELFReader) {
+TEST(LogicalViewTest, DWARFReader) {
// Initialize targets and assembly printers/parsers.
llvm::InitializeAllTargetInfos();
llvm::InitializeAllTargetMCs();
diff --git a/llvm/utils/gn/secondary/llvm/lib/DebugInfo/LogicalView/BUILD.gn b/llvm/utils/gn/secondary/llvm/lib/DebugInfo/LogicalView/BUILD.gn
index 763fdf21a1c81e..12b9540cc6d98e 100644
--- a/llvm/utils/gn/secondary/llvm/lib/DebugInfo/LogicalView/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/lib/DebugInfo/LogicalView/BUILD.gn
@@ -29,6 +29,6 @@ static_library("LogicalView") {
"Readers/LVBinaryReader.cpp",
"Readers/LVCodeViewReader.cpp",
"Readers/LVCodeViewVisitor.cpp",
- "Readers/LVELFReader.cpp",
+ "Readers/LVDWARFReader.cpp",
]
}
diff --git a/llvm/utils/gn/secondary/llvm/unittests/DebugInfo/LogicalView/BUILD.gn b/llvm/utils/gn/secondary/llvm/unittests/DebugInfo/LogicalView/BUILD.gn
index 9cbddd8af9a8f8..d87bac64e7b349 100644
--- a/llvm/utils/gn/secondary/llvm/unittests/DebugInfo/LogicalView/BUILD.gn
+++ b/llvm/utils/gn/secondary/llvm/unittests/DebugInfo/LogicalView/BUILD.gn
@@ -14,7 +14,7 @@ unittest("DebugInfoLogicalViewTests") {
"CodeViewReaderTest.cpp",
"CommandLineOptionsTest.cpp",
"CompareElementsTest.cpp",
- "ELFReaderTest.cpp",
+ "DWARFReaderTest.cpp",
"LocationRangesTest.cpp",
"LogicalElementsTest.cpp",
"SelectElementsTest.cpp",
>From 98cb3e4595f8c0fad9d4c347e90fb1dec54ece1a Mon Sep 17 00:00:00 2001
From: Carlos Alberto Enciso <carlos.alberto.enciso at gmail.com>
Date: Sat, 16 Mar 2024 14:45:08 +0000
Subject: [PATCH 2/2] [llvm-debuginfo-analyzer] Rename LVElfReader.cpp[h]
As part of the WebAssembly support work review
https://github.com/llvm/llvm-project/pull/82588
Fix clang-format issue.
---
llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
index 2417ad0d5cef06..22e804a459f873 100644
--- a/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
+++ b/llvm/include/llvm/DebugInfo/LogicalView/Readers/LVDWARFReader.h
@@ -129,7 +129,7 @@ class LVDWARFReader final : public LVBinaryReader {
public:
LVDWARFReader() = delete;
LVDWARFReader(StringRef Filename, StringRef FileFormatName,
- object::ObjectFile &Obj, ScopedPrinter &W)
+ object::ObjectFile &Obj, ScopedPrinter &W)
: LVBinaryReader(Filename, FileFormatName, W, LVBinaryType::ELF),
Obj(Obj) {}
LVDWARFReader(const LVDWARFReader &) = delete;
More information about the llvm-commits
mailing list