[llvm] [SystemZ][zOS] Override emitGlobalAlias for ADA (PR #84829)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 12 03:49:41 PDT 2024


================
@@ -1541,6 +1540,40 @@ void SystemZAsmPrinter::emitPPA2(Module &M) {
   OutStreamer->popSection();
 }
 
+void SystemZAsmPrinter::emitGlobalAlias(const Module &M,
+                                        const GlobalAlias &GA) {
----------------
uweigand wrote:

Why is this necessary?  This seems unrelated to the above change - there was no GlobalAlias involved as far as I can see.  Also, there doesn't appear to be any test case verifying what (if any) special handling is needed for GlobalAlias.  (B.t.w. is that special handling actually z/OS related, or is it rather GOFF related?  If the latter - there is XCOFF specific handling in emitGlobalAlias, so maybe the GOFF related special handling needs to go there too?)

https://github.com/llvm/llvm-project/pull/84829


More information about the llvm-commits mailing list