[llvm] [RemoveDIs] Update DIBuilder to conditionally insert DbgRecords (PR #84739)

[Stephen Tozer via llvm-commits]

SLTozer wrote:

> SGTM. We could even consider leaving the C interface in an "old-format-only-mode" until we completely remove the "old format".

That might work - though since the work is already done, perhaps the right order would be to have a patch that adds the RemoveDI-version of the C interface and an intrinsic-focused version, then in another patch change the original function to be the RemoveDIs version - that way the downstream consumers get a nudge, but have an immediate fix if needed (change instances of the existing function to the intrinsic version), then eventually we can delete the extra versions. Does that sound reasonable?

https://github.com/llvm/llvm-project/pull/84739