[llvm] [Xtensa] Implement base CallConvention. (PR #83280)

via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 7 16:48:03 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff c89d51112d329a4a37ff6dbcda7002853847c8a3 4689ab3959c9095441f56e3f41eca62ad3ece3ca -- llvm/lib/Target/Xtensa/MCTargetDesc/XtensaTargetStreamer.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaTargetStreamer.h llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h llvm/lib/Target/Xtensa/XtensaUtils.cpp llvm/lib/Target/Xtensa/XtensaUtils.h llvm/lib/Target/Xtensa/AsmParser/XtensaAsmParser.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp llvm/lib/Target/Xtensa/XtensaAsmPrinter.h llvm/lib/Target/Xtensa/XtensaFrameLowering.cpp llvm/lib/Target/Xtensa/XtensaFrameLowering.h llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp llvm/lib/Target/Xtensa/XtensaISelLowering.cpp llvm/lib/Target/Xtensa/XtensaISelLowering.h llvm/lib/Target/Xtensa/XtensaInstrInfo.cpp llvm/lib/Target/Xtensa/XtensaInstrInfo.h llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp b/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
index 8914ebf658..87ef66ba74 100644
--- a/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
+++ b/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
@@ -8,10 +8,10 @@
 //
 //===----------------------------------------------------------------------===//
 #include "XtensaMCTargetDesc.h"
+#include "TargetInfo/XtensaTargetInfo.h"
 #include "XtensaInstPrinter.h"
 #include "XtensaMCAsmInfo.h"
 #include "XtensaTargetStreamer.h"
-#include "TargetInfo/XtensaTargetInfo.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/MC/MCAsmInfo.h"
 #include "llvm/MC/MCInstrInfo.h"
diff --git a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
index 1cb1e577ae..902b29c4e7 100644
--- a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
@@ -72,8 +72,7 @@ void XtensaConstantPoolValue::print(raw_ostream &O) const {}
 
 XtensaConstantPoolConstant::XtensaConstantPoolConstant(
     const Constant *C, unsigned ID, XtensaCP::XtensaCPKind Kind)
-    : XtensaConstantPoolValue((Type *)C->getType(), ID, Kind),
-      CVal(C) {}
+    : XtensaConstantPoolValue((Type *)C->getType(), ID, Kind), CVal(C) {}
 
 XtensaConstantPoolConstant *
 XtensaConstantPoolConstant::Create(const Constant *C, unsigned ID,
@@ -147,8 +146,7 @@ void XtensaConstantPoolSymbol::print(raw_ostream &O) const {
 XtensaConstantPoolMBB::XtensaConstantPoolMBB(LLVMContext &C,
                                              const MachineBasicBlock *mbb,
                                              unsigned id)
-    : XtensaConstantPoolValue(C, 0, XtensaCP::CPMachineBasicBlock),
-      MBB(mbb) {}
+    : XtensaConstantPoolValue(C, 0, XtensaCP::CPMachineBasicBlock), MBB(mbb) {}
 
 XtensaConstantPoolMBB *
 XtensaConstantPoolMBB::Create(LLVMContext &C, const MachineBasicBlock *mbb,
@@ -205,4 +203,3 @@ void XtensaConstantPoolJumpTable::print(raw_ostream &O) const {
   O << "JT" << IDX;
   XtensaConstantPoolValue::print(O);
 }
-
diff --git a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
index c92ee5fd5f..8c80b0e0db 100644
--- a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
+++ b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
@@ -48,7 +48,7 @@ enum XtensaCPModifier {
 class XtensaConstantPoolValue : public MachineConstantPoolValue {
   unsigned LabelId;                    // Label id of the load.
   XtensaCP::XtensaCPKind Kind;         // Kind of constant.
-  XtensaCP::XtensaCPModifier Modifier; // Symbol name modifier 
+  XtensaCP::XtensaCPModifier Modifier; // Symbol name modifier
                                        //(for example Global Variable name)
 
 protected:
@@ -154,7 +154,6 @@ public:
   }
 };
 
-
 /// XtensaConstantPoolSymbol - Xtensa-specific constantpool values for external
 /// symbols.
 class XtensaConstantPoolSymbol : public XtensaConstantPoolValue {
diff --git a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
index ee0618d577..b3e6501b42 100644
--- a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
@@ -11,8 +11,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "XtensaConstantPoolValue.h"
 #include "XtensaISelLowering.h"
+#include "XtensaConstantPoolValue.h"
 #include "XtensaSubtarget.h"
 #include "XtensaTargetMachine.h"
 #include "llvm/CodeGen/CallingConvLower.h"

``````````

</details>


https://github.com/llvm/llvm-project/pull/83280


More information about the llvm-commits mailing list