[llvm] [llvm][AArch64] Autoupgrade function attributes from Module attributes. (PR #80640)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 01:16:31 PST 2024


nikic wrote:

This also causes an unreasonably large compile-time regression for what it does: https://llvm-compile-time-tracker.com/compare.php?from=354401f8d3dc08ed41895d03a12a122e9cc0482c&to=531e8c26b3f2626e7f1a997e0e8b61d67d10aded&stat=instructions:u Surely upgrading attributes should not take 0.5% compile-time during the clang thin link, especially on a target where these attributes do not even exist?

This logic should probably not be inside UpgradeFunctionAttributes() -- you'll want to structure this the other way around and first determine which module attributes (if any) have to be applied, and then apply them to all functions.

https://github.com/llvm/llvm-project/pull/80640


More information about the llvm-commits mailing list