[llvm] [HCS] Externd to outline overlapping sub/super cold regions (PR #80732)

via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 13:16:09 PST 2024


================
@@ -394,9 +382,16 @@ Function *HotColdSplitting::extractColdRegion(
   LLVM_DEBUG(dbgs() << "Split profitability: benefit = " << OutliningBenefit
                     << ", penalty = " << OutliningPenalty << "\n");
   if (!OutliningBenefit.isValid() || OutliningBenefit <= OutliningPenalty)
-    return nullptr;
+    return false;
+
+  return true;
+}
 
-  Function *OrigF = Region[0]->getParent();
+Function *HotColdSplitting::extractColdRegion(
----------------
hiraditya wrote:

Please add comment to clarify how BB is sufficient to extract a region. Is it a single-entry single-exit region?

https://github.com/llvm/llvm-project/pull/80732


More information about the llvm-commits mailing list