[llvm] [BOLT][DWARF] Add support for .debug_names (PR #81062)

Amir Ayupov via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 13:09:03 PST 2024


================
@@ -124,9 +125,10 @@ class DIEBuilder {
   std::vector<std::unique_ptr<DIEAbbrev>> Abbreviations;
   BinaryContext &BC;
   DWARFContext *DwarfContext{nullptr};
-  bool IsDWO{false};
+  DWARFUnit *SkeletonCU{nullptr};
----------------
aaupov wrote:

It greatly simplifies the review for reviewers like me who don't have the context of the problem area and have to make an effort to tell related and unrelated things apart. And second, it's within LLVM developer policy guidelines https://llvm.org/docs/DeveloperPolicy.html#incremental-development:

> Each change should be kept as small as possible. This simplifies your work (into a logical progression), simplifies code review and reduces the chance that you will get negative feedback on the change. Small increments also facilitate the maintenance of a high quality code base.



https://github.com/llvm/llvm-project/pull/81062


More information about the llvm-commits mailing list