[llvm] [DNR] [wip] working on windows buildkite presubmit (PR #82393)

Lucile Rose Nihlen via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 10:25:29 PST 2024


https://github.com/lnihlen updated https://github.com/llvm/llvm-project/pull/82393

>From 550ba12754272f7646857d66babd357dd4cef338 Mon Sep 17 00:00:00 2001
From: Lucile Nihlen <luci.the.rose at gmail.com>
Date: Tue, 20 Feb 2024 14:36:06 +0000
Subject: [PATCH 1/3] re-enable the windows build for testing

---
 .ci/generate-buildkite-pipeline-premerge | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index c14ec464a43a66..3ba402524f7f46 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -235,8 +235,8 @@ windows_projects_to_test=$(exclude-windows $(compute-projects-to-test ${modified
 windows_check_targets=$(check-targets ${windows_projects_to_test} | sort | uniq)
 # Temporary disable the windows job.
 # See https://discourse.llvm.org/t/rfc-future-of-windows-pre-commit-ci/76840
-#windows_projects=$(add-dependencies ${windows_projects_to_test} | sort | uniq)
-windows_projects=""
+windows_projects=$(add-dependencies ${windows_projects_to_test} | sort | uniq)
+#windows_projects=""
 
 # Generate the appropriate pipeline
 if [[ "${linux_projects}" != "" ]]; then

>From a17df951c6a41fb7df20e2a4e62ab24ba3510dbd Mon Sep 17 00:00:00 2001
From: Lucile Nihlen <luci.the.rose at gmail.com>
Date: Tue, 20 Feb 2024 18:11:50 +0000
Subject: [PATCH 2/3] force-enable windows presubmit

---
 .ci/generate-buildkite-pipeline-premerge | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge
index 3ba402524f7f46..a4b065c85bb88a 100755
--- a/.ci/generate-buildkite-pipeline-premerge
+++ b/.ci/generate-buildkite-pipeline-premerge
@@ -235,8 +235,10 @@ windows_projects_to_test=$(exclude-windows $(compute-projects-to-test ${modified
 windows_check_targets=$(check-targets ${windows_projects_to_test} | sort | uniq)
 # Temporary disable the windows job.
 # See https://discourse.llvm.org/t/rfc-future-of-windows-pre-commit-ci/76840
-windows_projects=$(add-dependencies ${windows_projects_to_test} | sort | uniq)
-#windows_projects=""
+#windows_projects=$(add-dependencies ${windows_projects_to_test} | sort | uniq)
+
+windows_projects="llvm"
+windows_check_targets="check-all"
 
 # Generate the appropriate pipeline
 if [[ "${linux_projects}" != "" ]]; then

>From 216c8ec79a7ff463522b131a337d5d04f5d4f16d Mon Sep 17 00:00:00 2001
From: Lucile Nihlen <luci.the.rose at gmail.com>
Date: Tue, 20 Feb 2024 18:25:10 +0000
Subject: [PATCH 3/3] try disabling manifests

---
 .ci/monolithic-windows.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index a704e855f011cb..2e204cdc98e472 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -49,7 +49,10 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D COMPILER_RT_BUILD_ORC=OFF \
       -D CMAKE_C_COMPILER_LAUNCHER=sccache \
       -D CMAKE_CXX_COMPILER_LAUNCHER=sccache \
-      -D MLIR_ENABLE_BINDINGS_PYTHON=ON
+      -D MLIR_ENABLE_BINDINGS_PYTHON=ON \
+      -D CMAKE_EXE_LINKER_FLAGS="/manifest:no" \
+      -D CMAKE_MODULE_LINKER_FLAGS="/manifest:no" \
+      -D CMAKE_SHARED_LINKER_FLAGS="/manifest:no"
 
 echo "--- ninja"
 # Targets are not escaped as they are passed as separate arguments.



More information about the llvm-commits mailing list