[llvm] Revert "Make two texts static in `ReplayInlineAdvisor`" (PR #82071)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 15:53:26 PST 2024


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/82071

Reverts llvm/llvm-project#79489

We know that the issues was with asan/annotations. We can revert it.

>From ceecdbf4881603844c25919f04fc86789bca69d5 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at gmail.com>
Date: Fri, 16 Feb 2024 15:52:11 -0800
Subject: [PATCH] Revert "Make two texts static in `ReplayInlineAdvisor`
 (#79489)"

This reverts commit 67f9c35ffee1aea3fa8a18b57a7b27400a03435a.
---
 llvm/lib/Analysis/ReplayInlineAdvisor.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Analysis/ReplayInlineAdvisor.cpp b/llvm/lib/Analysis/ReplayInlineAdvisor.cpp
index 0814483db343ce..2ca02eb1741712 100644
--- a/llvm/lib/Analysis/ReplayInlineAdvisor.cpp
+++ b/llvm/lib/Analysis/ReplayInlineAdvisor.cpp
@@ -43,8 +43,8 @@ ReplayInlineAdvisor::ReplayInlineAdvisor(
   //   main:3:1.1;
   // We use the callsite string after `at callsite` to replay inlining.
   line_iterator LineIt(*BufferOrErr.get(), /*SkipBlanks=*/true);
-  static const std::string PositiveRemark = "' inlined into '";
-  static const std::string NegativeRemark = "' will not be inlined into '";
+  const std::string PositiveRemark = "' inlined into '";
+  const std::string NegativeRemark = "' will not be inlined into '";
 
   for (; !LineIt.is_at_eof(); ++LineIt) {
     StringRef Line = *LineIt;



More information about the llvm-commits mailing list