[llvm] [CodeGen][ShrinkWrap] Clarify StackAddressUsedBlockInfo meaning (PR #80679)

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 04:47:24 PST 2024


================
@@ -161,9 +161,9 @@ class ShrinkWrap : public MachineFunctionPass {
   /// Current MachineFunction.
   MachineFunction *MachineFunc = nullptr;
 
-  /// Is `true` for block numbers where we can guarantee no stack access
-  /// or computation of stack-relative addresses on any CFG path including
-  /// the block itself.
+  /// Is `true` for the block numbers where we cannot guarantee that there will
+  /// be no access to the stack or computation of stack-relative addresses on
+  /// any CFG path including the block itself.
----------------
qcolombet wrote:

The comment is indeed out of date.
Is true => there may be a stack access or computation of ... (i.e., just drop the `no` from the original comment)
Is false => no stack access  or computation

https://github.com/llvm/llvm-project/pull/80679


More information about the llvm-commits mailing list