[llvm] [LV] Disable fold tail by masking - when induction vars used outside (PR #81609)

Niwin Anto via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 13 11:58:39 PST 2024


niwinanto wrote:

> Thanks for the patch!
> 
> Could you add the test as a separate PR (with a FIXME); this patch then just adjust the test and the diff shows the change in the test only.
> 
> Previously there was a patch shared here https://reviews.llvm.org/D115109 by @rickyz (hope it's the same as on Phabricator) but the patch never got pushed through. Would be good to look at the comments and potentially pick it up

Thanks @fhahn for the reviews. Great that you mentioned the Phabricator patch, the test looks good and I copied here.  As you suggested, created new pr for the test case with default behavior(https://github.com/niwinanto/llvm-project/pull/2/commits/33ec3081832a950369ced6d1e8913ac771e689de) and then updated this pr. However, I messed with the git workflow(I think). Could you please take a look, this is what you intended.

https://github.com/llvm/llvm-project/pull/81609


More information about the llvm-commits mailing list