[compiler-rt] [hwasan] Call user provided callback function for both fatal and non-… (PR #80429)

via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 6 18:17:18 PST 2024


Enna1 wrote:

> tbh I am not sure who uses this API, so I am not sure if this behavior change could cause any problems

Thanks for the review!

This change makes the behavior of hwasan matching with asan.
https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/asan/asan_report.cpp#L173-L183
Always call user provided callback function for an error report, but only call `android_set_abort_message()` on Android when `flags()->halt_on_error` is true.

In my use case,  I collect every error report text and upload it to storage using `__hwasan_set_error_report_callback()`:)


https://github.com/llvm/llvm-project/pull/80429


More information about the llvm-commits mailing list