[llvm] GlobalISel needs fdiv 1 / sqrt(x) to rsq combine (PR #78673)

Pierre van Houtryve via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 4 23:19:20 PST 2024


Pierre-vh wrote:

> @Pierre-vh I am waiting for @arsenm's approval since he opened the issue. But, do you know why I do not have the ability to merge the PR (because I don't have write access)? I do not see the "Merge Pull Request" button. And, do you know if there is something I can do to make the button available to me? That way I do not have to ask others to merge for me? I attached a screen shot of where I would expect to see the button. <img alt="Screenshot 2024-02-03 at 2 23 07 PM" width="946" src="https://private-user-images.githubusercontent.com/44080390/302065354-fd37095a-a34c-4ef2-9bf5-4da687e32af0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDcxMTc2OTMsIm5iZiI6MTcwNzExNzM5MywicGF0aCI6Ii80NDA4MDM5MC8zMDIwNjUzNTQtZmQzNzA5NWEtYTM0Yy00ZWYyLTliZjUtNGRhNjg3ZTMyYWYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMjA1VDA3MTYzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiZTA1ZjAzMGJmZjU2YjBhN2ViNWZkYzU5YjdkYzBhNjllOTE2ZGQ1ZWQ0MmM2Y2NmMzMxNjQ3ZmEwMDYxMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EuXcK0rLNz965UPF0g47I1Kp--gs65-J7yIWkFN3eNU">

I assume you don't have commit access? Then you won't be able to merge yourself, but we can do it.
Once you have merged a few patches, you can ask for commit access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

https://github.com/llvm/llvm-project/pull/78673


More information about the llvm-commits mailing list