[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

Zahira Ammarguellat via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 10:46:14 PST 2024


zahiraam wrote:

> Hi, I am seeing breakages on some of our audio code on tip of tree Clang and I traced it back to this patch.
> 
> We uses `-ffast-math` mode for performance reasons but we also uses `-fhonor-infinities`, `-fhonor-nans` and `fno-finite-math-only` to ensure that the behavior of infinity is correct. But the message `error: use of infinity is undefined behavior due to the currently enabled floating-point options [-Werror,-Wnan-infinity-disabled] ` was still produced by the compiler. Is this intended behavior? If not, could you revert, revise and reland the change please?
> 
> Thanks.

I think this must be related to the comment above. I am in process of creating a PR to fix it. But if it can't wait I will revert this.
See https://godbolt.org/z/r154xP11W

https://github.com/llvm/llvm-project/pull/76873


More information about the llvm-commits mailing list