[llvm] [HWASAN] NFC? Remove DW_OP_LLVM_tag_offset from DIExpression::isImplicit (PR #79816)

J. Ryan Stinnett via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 03:55:58 PST 2024


jryans wrote:

> I think in all these cases it is a mistake to treat an expression containing only a `DW_OP_LLVM_tag_offset` opcode as "implicit (which this patch fixes).

I agree with your analysis above. `DW_OP_LLVM_tag_offset` does not make the expression become a value instead of location, which seems to be what `isImplicit` is testing. So, this change seems correct to me.

https://github.com/llvm/llvm-project/pull/79816


More information about the llvm-commits mailing list